From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20257 invoked by alias); 6 Jan 2011 04:32:13 -0000 Received: (qmail 20249 invoked by uid 22791); 6 Jan 2011 04:32:13 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Jan 2011 04:32:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BDCEA2BAC4C; Wed, 5 Jan 2011 23:32:06 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Xced0cQ9rwUJ; Wed, 5 Jan 2011 23:32:06 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2CF5A2BAC2C; Wed, 5 Jan 2011 23:32:05 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 702901459AD; Thu, 6 Jan 2011 08:31:58 +0400 (RET) Date: Thu, 06 Jan 2011 04:32:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: Pierre Muller , "gdb-patches@sourceware.org" Subject: Re: [patch] Shorten lines of >= 80 columns. Message-ID: <20110106043158.GB28888@adacore.com> References: <4D237089.1080309@vmware.com> <000c01cbac44$48830210$d9890630$@muller@ics-cnrs.unistra.fr> <4D237C6A.9050609@vmware.com> <000001cbacb7$4fc38f40$ef4aadc0$@muller@ics-cnrs.unistra.fr> <4D24B777.4030403@vmware.com> <4D24E4B9.40500@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D24E4B9.40500@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00110.txt.bz2 > internal_error (__FILE__, __LINE__, > _("gen_var_ref: LOC_CONST_BYTES " > "symbols are not supported")); For one-line strings, I think that's an acceptable solution. In fact, this might be a better solution, making the code as a whole more readable (because it avoids the misindentation of the string that breaks the formatting of the code as a whole). For multi-line strings, such as help strings, etc, I think it will be easier to still use the style that you originally chose. For instance: | warning (_("\ | Private mapping of shared library text was not specified\n\ | by the executable; setting a breakpoint in a shared library which\n\ | is not privately mapped will not work. See the HP-UX 11i v3 chatr\n\ | manpage for methods to privately map shared library text.")); I think that, for multi-line strings, this makes easier to read the entire text, and it also makes it easier to make sure that the string is of reasonable size (ie, under 80, or 76, or 74). The typical case where these are used are the _init routines, where we create new commands. The help strings can easily need to have more than one line (if it was me, I would put as much information in the help command as in the manual). -- Joel