From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-77428-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23335 invoked by alias); 5 Jan 2011 22:57:39 -0000
Received: (qmail 23327 invoked by uid 22791); 5 Jan 2011 22:57:38 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Jan 2011 22:57:34 +0000
Received: (qmail 26222 invoked from network); 5 Jan 2011 22:57:32 -0000
Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 5 Jan 2011 22:57:32 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch] Add "debug jit" for easier tracing of JIT support internals
Date: Wed, 05 Jan 2011 22:57:00 -0000
User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; )
Cc: Doug Evans <dje@google.com>, Paul Pluzhnikov <ppluzhnikov@google.com>
References: <20110105193621.A8CBF190B3A@elbrus2.mtv.corp.google.com> <AANLkTiks2fAEGXVwBxbOJZYaGmVLGPKHdrQ0fdM=ELDn@mail.gmail.com>
In-Reply-To: <AANLkTiks2fAEGXVwBxbOJZYaGmVLGPKHdrQ0fdM=ELDn@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201101052257.30806.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-01/txt/msg00096.txt.bz2

On Wednesday 05 January 2011 20:01:50, Doug Evans wrote:
> Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> > +
> > +static void
> > +show_jit_debug (struct ui_file *file, int from_tty,
> > +               struct cmd_list_element *c, const char *value)
> > +{
> > +  fprintf_filtered (file, _("JIT debugging is %s.\n"), value);
> > +}
> > +

...

> and while I haven't tried it, I wonder if show_jit_debug is necessary
> (bummer if it is, we should fix that).

It's necessary for i18n.  The default callback (deprecated_show_value_hack)
does:

  /* Print doc minus "show" at start.  */
  print_doc_line (gdb_stdout, c->doc + 5);

which obviously only works in English.

Until and if we find a better way, an implemented show callback
should be a requirement for all new commands.

-- 
Pedro Alves