From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31944 invoked by alias); 4 Jan 2011 19:27:54 -0000 Received: (qmail 31934 invoked by uid 22791); 4 Jan 2011 19:27:53 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Jan 2011 19:27:46 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p04JRfZL018126; Tue, 4 Jan 2011 20:27:41 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p04JRewd032364; Tue, 4 Jan 2011 20:27:40 +0100 (CET) Date: Tue, 04 Jan 2011 19:27:00 -0000 Message-Id: <201101041927.p04JRewd032364@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: msnyder@vmware.com CC: gdb-patches@sourceware.org In-reply-to: <4D237089.1080309@vmware.com> (message from Michael Snyder on Tue, 04 Jan 2011 11:10:01 -0800) Subject: Re: [patch] Shorten lines of >= 80 columns. References: <4D237089.1080309@vmware.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00065.txt.bz2 > Date: Tue, 04 Jan 2011 11:10:01 -0800 > From: Michael Snyder > > I would like to propose that this type of change be regarded as "obvious". yes ;) > 2011-01-04 Michael Snyder > > * addrmap.c: Shorten lines of >= 80 columns. > * arch-utils.c: Ditto. > * arch-utils.h: Ditto. > * ax-gdb.c: Ditto. > * ax-general.c: Ditto. > > Index: addrmap.c > =================================================================== > RCS file: /cvs/src/src/gdb/addrmap.c,v > retrieving revision 1.10 > diff -u -p -r1.10 addrmap.c > --- addrmap.c 1 Jan 2011 15:32:56 -0000 1.10 > +++ addrmap.c 4 Jan 2011 19:06:08 -0000 > @@ -307,7 +307,8 @@ addrmap_node_set_value (splay_tree_node > > > static void > -addrmap_splay_tree_insert (struct addrmap_mutable *map, CORE_ADDR key, void *value) > +addrmap_splay_tree_insert (struct addrmap_mutable *map, > + CORE_ADDR key, void *value) > { > splay_tree_insert (map->tree, > allocate_key (map, key), > Index: arch-utils.c > =================================================================== > RCS file: /cvs/src/src/gdb/arch-utils.c,v > retrieving revision 1.191 > diff -u -p -r1.191 arch-utils.c > --- arch-utils.c 1 Jan 2011 15:32:57 -0000 1.191 > +++ arch-utils.c 4 Jan 2011 19:06:08 -0000 > @@ -788,7 +788,8 @@ default_remote_breakpoint_from_pc (struc > > /* */ > > -extern initialize_file_ftype _initialize_gdbarch_utils; /* -Wmissing-prototypes */ > +/* -Wmissing-prototypes */ > +extern initialize_file_ftype _initialize_gdbarch_utils; > > void > _initialize_gdbarch_utils (void) > Index: arch-utils.h > =================================================================== > RCS file: /cvs/src/src/gdb/arch-utils.h,v > retrieving revision 1.112 > diff -u -p -r1.112 arch-utils.h > --- arch-utils.h 1 Jan 2011 15:32:57 -0000 1.112 > +++ arch-utils.h 4 Jan 2011 19:06:08 -0000 > @@ -51,8 +51,8 @@ extern void > > /* Default implementation of gdbarch_displaced_hw_singlestep. */ > extern int > - default_displaced_step_hw_singlestep (struct gdbarch *gdbarch, > - struct displaced_step_closure *closure); > + default_displaced_step_hw_singlestep (struct gdbarch *, > + struct displaced_step_closure *); > > /* Possible value for gdbarch_displaced_step_location: > Place displaced instructions at the program's entry point, > @@ -74,7 +74,8 @@ extern int no_op_reg_to_regnum (struct g > > /* Do nothing version of elf_make_msymbol_special. */ > > -void default_elf_make_msymbol_special (asymbol *sym, struct minimal_symbol *msym); > +void default_elf_make_msymbol_special (asymbol *sym, > + struct minimal_symbol *msym); > > /* Do nothing version of coff_make_msymbol_special. */ > > @@ -100,7 +101,8 @@ extern CORE_ADDR generic_skip_solib_reso > extern int generic_in_solib_return_trampoline (struct gdbarch *gdbarch, > CORE_ADDR pc, char *name); > > -extern int generic_in_function_epilogue_p (struct gdbarch *gdbarch, CORE_ADDR pc); > +extern int generic_in_function_epilogue_p (struct gdbarch *gdbarch, > + CORE_ADDR pc); > > /* By default, registers are not convertible. */ > extern int generic_convert_register_p (struct gdbarch *gdbarch, int regnum, > Index: ax-gdb.c > =================================================================== > RCS file: /cvs/src/src/gdb/ax-gdb.c,v > retrieving revision 1.81 > diff -u -p -r1.81 ax-gdb.c > --- ax-gdb.c 1 Jan 2011 15:32:57 -0000 1.81 > +++ ax-gdb.c 4 Jan 2011 19:06:08 -0000 > @@ -70,7 +70,8 @@ static struct value *const_var_ref (stru > static struct value *const_expr (union exp_element **pc); > static struct value *maybe_const_expr (union exp_element **pc); > > -static void gen_traced_pop (struct gdbarch *, struct agent_expr *, struct axs_value *); > +static void gen_traced_pop (struct gdbarch *, struct agent_expr *, > + struct axs_value *); > > static void gen_sign_extend (struct agent_expr *, struct type *); > static void gen_extend (struct agent_expr *, struct type *); > @@ -632,8 +633,8 @@ gen_var_ref (struct gdbarch *gdbarch, st > break; > > case LOC_CONST_BYTES: > - internal_error (__FILE__, __LINE__, > - _("gen_var_ref: LOC_CONST_BYTES symbols are not supported")); > + internal_error (__FILE__, __LINE__, _("\ > +gen_var_ref: LOC_CONST_BYTES symbols are not supported")); > > /* Variable at a fixed location in memory. Easy. */ > case LOC_STATIC: > @@ -1138,8 +1139,9 @@ gen_less (struct agent_expr *ax, struct > operator, used in error messages */ > static void > gen_binop (struct agent_expr *ax, struct axs_value *value, > - struct axs_value *value1, struct axs_value *value2, enum agent_op op, > - enum agent_op op_unsigned, int may_carry, char *name) > + struct axs_value *value1, struct axs_value *value2, > + enum agent_op op, enum agent_op op_unsigned, > + int may_carry, char *name) > { > /* We only handle INT op INT. */ > if ((TYPE_CODE (value1->type) != TYPE_CODE_INT) > @@ -1447,7 +1449,8 @@ gen_struct_ref_recursive (struct express > { > gen_static_field (exp->gdbarch, ax, value, type, i); > if (value->optimized_out) > - error (_("static field `%s' has been optimized out, cannot use"), > + error (_("\ > +static field `%s' has been optimized out, cannot use"), > field); > return 1; > } > @@ -1469,7 +1472,8 @@ gen_struct_ref_recursive (struct express > struct type *basetype = check_typedef (TYPE_BASECLASS (type, i)); > > rslt = gen_struct_ref_recursive (exp, ax, value, field, > - offset + TYPE_BASECLASS_BITPOS (type, i) / TARGET_CHAR_BIT, > + offset + TYPE_BASECLASS_BITPOS (type, i) > + / TARGET_CHAR_BIT, > basetype); > if (rslt) > return 1; > @@ -1587,7 +1591,8 @@ gen_struct_elt_for_reference (struct exp > { > gen_static_field (exp->gdbarch, ax, value, t, i); > if (value->optimized_out) > - error (_("static field `%s' has been optimized out, cannot use"), > + error (_("\ > +static field `%s' has been optimized out, cannot use"), > fieldname); > return 1; > } > @@ -1706,7 +1711,8 @@ gen_repeat (struct expression *exp, unio > int length; > > if (!v) > - error (_("Right operand of `@' must be a constant, in agent expressions.")); > + error (_("\ > +Right operand of `@' must be a constant, in agent expressions.")); > if (TYPE_CODE (value_type (v)) != TYPE_CODE_INT) > error (_("Right operand of `@' must be an integer.")); > length = value_as_long (v); > @@ -1890,7 +1896,8 @@ gen_expr (struct expression *exp, union > ax_tsv (ax, aop_tracev, tsv->number); > } > else > - error (_("$%s is not a trace state variable, may not assign to it"), name); > + error (_("\ > +$%s is not a trace state variable, may not assign to it"), name); > } > else > error (_("May only assign to trace state variables")); > @@ -1925,7 +1932,8 @@ gen_expr (struct expression *exp, union > ax_tsv (ax, aop_tracev, tsv->number); > } > else > - error (_("$%s is not a trace state variable, may not assign to it"), name); > + error (_("\ > +$%s is not a trace state variable, may not assign to it"), name); > } > else > error (_("May only assign to trace state variables")); > @@ -2007,7 +2015,8 @@ gen_expr (struct expression *exp, union > value->type = builtin_type (exp->gdbarch)->builtin_long_long; > } > else > - error (_("$%s is not a trace state variable; GDB agent expressions cannot use convenience variables."), name); > + error (_("$%s is not a trace state variable; GDB agent " > + "expressions cannot use convenience variables."), name); > } > break; > > @@ -2268,7 +2277,8 @@ cannot subscript requested type: cannot > } > > if (!is_integral_type (value2->type)) > - error (_("Argument to arithmetic operation not a number or boolean.")); > + error (_("\ > +Argument to arithmetic operation not a number or boolean.")); > > gen_ptradd (ax, value, value1, value2); > gen_deref (ax, value); > @@ -2510,11 +2520,11 @@ void _initialize_ax_gdb (void); > void > _initialize_ax_gdb (void) > { > - add_cmd ("agent", class_maintenance, agent_command, > - _("Translate an expression into remote agent bytecode for tracing."), > + add_cmd ("agent", class_maintenance, agent_command, _("\ > +Translate an expression into remote agent bytecode for tracing."), > &maintenancelist); > > - add_cmd ("agent-eval", class_maintenance, agent_eval_command, > - _("Translate an expression into remote agent bytecode for evaluation."), > + add_cmd ("agent-eval", class_maintenance, agent_eval_command, _("\ > +Translate an expression into remote agent bytecode for evaluation."), > &maintenancelist); > } > Index: ax-general.c > =================================================================== > RCS file: /cvs/src/src/gdb/ax-general.c,v > retrieving revision 1.22 > diff -u -p -r1.22 ax-general.c > --- ax-general.c 1 Jan 2011 15:32:57 -0000 1.22 > +++ ax-general.c 4 Jan 2011 19:06:08 -0000 > @@ -154,7 +154,8 @@ generic_ext (struct agent_expr *x, enum > error (_("GDB bug: ax-general.c (generic_ext): bit count out of range")); > /* That had better be enough range. */ > if (sizeof (LONGEST) * 8 > 255) > - error (_("GDB bug: ax-general.c (generic_ext): opcode has inadequate range")); > + error (_("\ > +GDB bug: ax-general.c (generic_ext): opcode has inadequate range")); > > grow_expr (x, 2); > x->buf[x->len++] = op; > @@ -184,7 +185,8 @@ ax_trace_quick (struct agent_expr *x, in > { > /* N must fit in a byte. */ > if (n < 0 || n > 255) > - error (_("GDB bug: ax-general.c (ax_trace_quick): size out of range for trace_quick")); > + error (_("\ > +GDB bug: ax-general.c (ax_trace_quick): size out of range for trace_quick")); > > grow_expr (x, 2); > x->buf[x->len++] = aop_trace_quick; > @@ -265,7 +267,8 @@ void > ax_const_d (struct agent_expr *x, LONGEST d) > { > /* FIXME: floating-point support not present yet. */ > - error (_("GDB bug: ax-general.c (ax_const_d): floating point not supported yet")); > + error (_("\ > +GDB bug: ax-general.c (ax_const_d): floating point not supported yet")); > } > > > @@ -289,7 +292,8 @@ ax_reg (struct agent_expr *x, int reg) > { > /* Make sure the register number is in range. */ > if (reg < 0 || reg > 0xffff) > - error (_("GDB bug: ax-general.c (ax_reg): register number out of range")); > + error (_("\ > +GDB bug: ax-general.c (ax_reg): register number out of range")); > grow_expr (x, 3); > x->buf[x->len] = aop_reg; > x->buf[x->len + 1] = (reg >> 8) & 0xff; > @@ -305,7 +309,8 @@ ax_tsv (struct agent_expr *x, enum agent > { > /* Make sure the tsv number is in range. */ > if (num < 0 || num > 0xffff) > - internal_error (__FILE__, __LINE__, _("ax-general.c (ax_tsv): variable number is %d, out of range"), num); > + internal_error (__FILE__, __LINE__, _("\ > +ax-general.c (ax_tsv): variable number is %d, out of range"), num); > > grow_expr (x, 3); > x->buf[x->len] = op; > > --------------040907020103030700010102-- >