From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9178 invoked by alias); 3 Jan 2011 08:05:02 -0000 Received: (qmail 9153 invoked by uid 22791); 3 Jan 2011 08:05:01 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Jan 2011 08:04:57 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p0384Vgj029789; Mon, 3 Jan 2011 09:04:31 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p0384T2N020327; Mon, 3 Jan 2011 09:04:29 +0100 (CET) Date: Mon, 03 Jan 2011 08:05:00 -0000 Message-Id: <201101030804.p0384T2N020327@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: brobecker@adacore.com CC: msnyder@vmware.com, eliz@gnu.org, hjl.tools@gmail.com, gdb-patches@sourceware.org In-reply-to: <20110103043359.GO2396@adacore.com> (message from Joel Brobecker on Mon, 3 Jan 2011 08:33:59 +0400) Subject: Re: [patch] more comment cleanups References: <4D1E60A0.1020601@vmware.com> <201012312312.oBVNC4fc013647@glazunov.sibelius.xs4all.nl> <4D1E732E.4090002@vmware.com> <834o9tq96f.fsf@gnu.org> <4D1F71B0.9060006@vmware.com> <20110103043359.GO2396@adacore.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00035.txt.bz2 > Date: Mon, 3 Jan 2011 08:33:59 +0400 > From: Joel Brobecker > > > So what do others think about source lines over 70 columns? > > Enforcing a maximum length of 70 characters seems awfully low to me. > It's fine if someone decides to use 70 characters for his comments, > of even his code, but I think that 76 or 78 would give better results. > I even allow myself to go up to 80 when splitting a line makes it > particularly ugly and hard to read... 70 characters really isn't that low for comments that start in the first column; look at a properly typeset book and count the number of characters per line. However, I fully agree with you that it shouldn't be strictly enforced. If for example, it means that you end up wrapping a single line comment such that you end up with a single word on the next line I strongly prefer not to wrap and keep the comment on one line such that it takes up less vertical space. The same holds for code. If I can keep things on a single line, I'll attempt to do so, even if it means I'll get a little bit closer to the 80 character "hard" limit. It's one of the reasons I never believed in running tools like indent to automatically format source code.