Re: [RFA/RFC] mips tracepoint: fix Bug 12013

Mark Kettenis
2010-12-19T10:39:37Z

> From: Hui Zhu <teawater@gmail.com>
> Date: Sun, 19 Dec 2010 16:35:59 +0800
>
> http://sourceware.org/bugzilla/show_bug.cgi?id=12013
>
> This bug make mips tracepoint cannot trace the backtrace.
>
> This patch to fix this issue with a directly way just remove the
> decline of access to the raw register names.
>
> If you think it's not OK. What about add a new interface to gdbarch
> to access to the raw register names.

It is a common trick to return an empty register name for a (raw)
register to hide the register from the user. So I don't think this
diff is ok, since the goal obviously is to hide the raw registers in
mips in favour of the pseudo registers.

I'd say the proper way forward is to teach the trace code to handle
pseudo registers.

> 2010-12-19 Hui Zhu <teawater@gmail.com>
>
> * mips-tdep.c (mips_register_name): Remove the check.
> (mips_print_registers_info): Remove the gdb_assert.
>