From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12862 invoked by alias); 29 Dec 2010 10:21:18 -0000 Received: (qmail 12852 invoked by uid 22791); 29 Dec 2010 10:21:17 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_50 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Dec 2010 10:21:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1BCC62BABE9; Wed, 29 Dec 2010 05:21:11 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id cRITbC1kJ1uE; Wed, 29 Dec 2010 05:21:11 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 76DD52BABB4; Wed, 29 Dec 2010 05:21:10 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 5C9E5145870; Wed, 29 Dec 2010 14:21:03 +0400 (RET) Date: Wed, 29 Dec 2010 11:16:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [patch] comment cleanup Message-ID: <20101229102103.GA7592@adacore.com> References: <4D1A8801.8050802@vmware.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="zhXaljGHf11kAtnf" Content-Disposition: inline In-Reply-To: <4D1A8801.8050802@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00542.txt.bz2 --zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1208 > 2010-12-28 Michael Snyder > > * event-loop.c: Comment clean-up. > * event-loop.h: Ditto. > * event-top.c: Ditto. > * gdb.c: Ditto. > * gdb.h: Ditto. > * main.c: Ditto. > * top.c: Ditto. > * top.h: Ditto. I just noticed that gdb.c contains unadvertized code updates :-), and this is causing the build to fail on platforms where mcheck.h is not available (Eg. ppc-aix). These have now been reverted with the following commit. > Index: gdb.c > =================================================================== > RCS file: /cvs/src/src/gdb/gdb.c,v > retrieving revision 1.9 > diff -u -p -r1.9 gdb.c > --- gdb.c 14 May 2010 20:17:37 -0000 1.9 > +++ gdb.c 29 Dec 2010 00:53:53 -0000 > @@ -20,16 +20,21 @@ > #include "main.h" > #include "gdb_string.h" > #include "interps.h" > +#include > > int > main (int argc, char **argv) > { > struct captured_main_args args; > + int ret; > > + mtrace (); > memset (&args, 0, sizeof args); > args.argc = argc; > args.argv = argv; > args.use_windows = 0; > args.interpreter_p = INTERP_CONSOLE; > - return gdb_main (&args); > + ret = gdb_main (&args); > + muntrace(); > + return ret; -- Joel --zhXaljGHf11kAtnf Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="gdb.diff" Content-length: 1297 commit f185a672c4ad8b37ba3b0d297b2240b004aad6a7 Author: Joel Brobecker Date: Wed Dec 29 14:17:12 2010 +0400 revert previous gdb.c commit (it was not a minor comment update) gdb/ChangeLog: * gdb.c: Revert the previous change, which was probably committed by accident. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 43bba0c..b7be1ad 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2010-12-29 Joel Brobecker + * gdb.c: Revert the previous change, which was probably committed + by accident. + +2010-12-29 Joel Brobecker + * ada-lang.c: Fix typo in comment. 2010-12-29 Joel Brobecker diff --git a/gdb/gdb.c b/gdb/gdb.c index 74f806e..bc5e6cc 100644 --- a/gdb/gdb.c +++ b/gdb/gdb.c @@ -20,21 +20,16 @@ #include "main.h" #include "gdb_string.h" #include "interps.h" -#include int main (int argc, char **argv) { struct captured_main_args args; - int ret; - mtrace (); memset (&args, 0, sizeof args); args.argc = argc; args.argv = argv; args.use_windows = 0; args.interpreter_p = INTERP_CONSOLE; - ret = gdb_main (&args); - muntrace(); - return ret; + return gdb_main (&args); } --zhXaljGHf11kAtnf--