From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14302 invoked by alias); 29 Dec 2010 02:39:33 -0000 Received: (qmail 14292 invoked by uid 22791); 29 Dec 2010 02:39:32 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Dec 2010 02:39:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F346D2BABBC; Tue, 28 Dec 2010 21:39:26 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1nxyYF8yjPjP; Tue, 28 Dec 2010 21:39:26 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5E9F12BABB8; Tue, 28 Dec 2010 21:39:26 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 95E4A145870; Wed, 29 Dec 2010 06:39:19 +0400 (RET) Date: Wed, 29 Dec 2010 02:49:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Subject: Re: [PATCH] sim: HW_NZALLOC: fix arg handling Message-ID: <20101229023919.GB2396@adacore.com> References: <1293587541-16750-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1293587541-16750-1-git-send-email-vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00530.txt.bz2 > The HW_NZALLOC macro has all caps args for some reason (unlike the other > alloc helpers), and ends up not using the "ME" argument since its copy > and paste source uses "me". Make all the args lowercase to match the > style of all the other args and make it use the correct "me". Interesting catch... > Signed-off-by: Mike Frysinger > > 2010-12-28 Mike Frysinger > > * hw-alloc.h (HW_NZALLOC): Change ME,TYPE,N to me,type,n. This is OK. Thanks for fixing this. -- Joel