From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2551 invoked by alias); 28 Dec 2010 17:24:08 -0000 Received: (qmail 2539 invoked by uid 22791); 28 Dec 2010 17:24:08 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Dec 2010 17:24:03 +0000 Received: (qmail 5130 invoked from network); 28 Dec 2010 17:24:02 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Dec 2010 17:24:02 -0000 From: Pedro Alves To: Joel Brobecker Subject: Re: [RFA/RFC] mips tracepoint: fix Bug 12013 Date: Tue, 28 Dec 2010 19:05:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; ) Cc: Hui Zhu , gdb-patches@sourceware.org, Kevin Buettner References: <20101228170851.GA2396@adacore.com> In-Reply-To: <20101228170851.GA2396@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201012281723.59829.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00518.txt.bz2 On Tuesday 28 December 2010 17:08:52, Joel Brobecker wrote: > > Joel, do you think this patch can check in to 7.2.1. > > I think that it's borderline, and I'm tempted to say no, considering > that this is not a crash or a regression (just a limitation). But > it looks relatively safe to me. So, if Pedro agrees, it's OK with me. Yeah. I understand that without this patch, MIPS tracepoints are practically useless on 7.2, so on those grounds, I'd be okay. However, I just went to check whether collecting a pseudo or user register in x86/x86_64 still gives a reasonable error, and I now get: >./gdb -q ./gdb Reading symbols from /home/pedro/gdb/baseline/build/gdb/gdb...done. (top-gdb) start Temporary breakpoint 3 at 0x4565c3: file ../../src/gdb/gdb.c, line 29. Starting program: /home/pedro/gdb/baseline/build/gdb/gdb [Thread debugging using libthread_db enabled] Temporary breakpoint 3, main (argc=1, argv=0x7fffffffe108) at ../../src/gdb/gdb.c:29 29 memset (&args, 0, sizeof args); (top-gdb) maint agent $sp ../../src/gdb/regcache.c:166: internal-error: register_type: Assertion `regnum >= 0 && regnum < descr->nr_cooked_registers' failed. A problem internal to GDB has been detected, further debugging may prove unreliable. Quit this debugging session? (y or n) While before (on 7.2), we'd get: (top-gdb) maint agent $sp 'sp' is a pseudo-register; GDB cannot yet trace pseudoregister contents. We'll need to get this fixed this before considering a backport to 7.2. -- Pedro Alves