From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18316 invoked by alias); 28 Dec 2010 05:00:58 -0000 Received: (qmail 18299 invoked by uid 22791); 28 Dec 2010 05:00:57 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Dec 2010 05:00:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4993D2BAB68; Tue, 28 Dec 2010 00:00:52 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Jsko6SKYh1UJ; Tue, 28 Dec 2010 00:00:52 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A63D02BAB38; Tue, 28 Dec 2010 00:00:51 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C45F11457BB; Tue, 28 Dec 2010 06:00:42 +0100 (CET) Date: Tue, 28 Dec 2010 05:47:00 -0000 From: Joel Brobecker To: Thiago Jung Bauermann Cc: Pedro Alves , gdb-patches@sourceware.org, Jan Kratochvil , Eli Zaretskii Subject: Re: [patch 2/3] Implement support for PowerPC BookE ranged watchpoints Message-ID: <20101228050042.GB2596@adacore.com> References: <1290549100.3164.47.camel@hactar> <201011271747.39053.pedro@codesourcery.com> <1293130182.14239.21.camel@hactar> <201012232017.11120.pedro@codesourcery.com> <1293484743.1544.78.camel@hactar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1293484743.1544.78.camel@hactar> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00489.txt.bz2 > +/* Return true if TYPE is scalar. */ > + > +int > +is_scalar_type (struct type *type) > +{ > + CHECK_TYPEDEF (type); > + > + while (TYPE_CODE (type) == TYPE_CODE_REF) > + { > + type = TYPE_TARGET_TYPE (type); > + CHECK_TYPEDEF (type); > + } I suggest you make it explicit how TYPE_CODE_REF types are handled. In certain cases, I think it might be making a difference (a REF to a struct might have a different classification than the struct in terms of argument passing, for instance). -- Joel