Re: [patch 2/2] Implement gdbarch hook user_register_name on ARM

Ulrich Weigand
2010-12-22T22:02:14Z

Yao Qi wrote:

> Good catch! set_gdbarch_deprecated_fp_regnum is called in
> arm_gdbarch_init since 2003, introduced by this patch "Deprecate
> TARGET_READ_FP, read_fp and FP_REGNUM"
> http://sourceware.org/ml/gdb-patches/2003-04/msg00471.html
>
> set_gdbarch_deprecated_fp_regnum is no longer used in most of targets,
> and I don't see any reason why we have to keep it in ARM, so I draft
> this one-line patch.

Huh, I didn't even see this, I was refering to this line:
{ "fp", 11 },
in arm_register_aliases. As long as this line is there, changes to
set_gdbarch_deprecated_fp_regnum probably don't matter as this isn't
even evaluated, since "fp" is just treated as a user register instead
of a standard register.

But you're right that you need to remove the set_gdbarch_deprecated_fp_regnum
*also* in order to get the full default logic I had described.

Bye,
Ulrich

--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com