From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfa] Update PC without side effect in displaced stepping
Date: Thu, 23 Dec 2010 04:54:00 -0000 [thread overview]
Message-ID: <20101223042236.GS2596@adacore.com> (raw)
In-Reply-To: <4D10D377.8080100@codesourcery.com>
> When writing the new patch, I re-consider this problem again. GDB
> doesn't support displaced stepping on sparc and hppa, so it is not
> harmful to sparc and hppa when regcache_write_pc is replaced by
> regcache_cooked_write_unsigned.
> Currently, GDB supports displaced stepping on s390, rs6000 (including
> ppc-linux, aix), i386, amd64 and arm. AFAICS, this replacement in my
> original patch is not harmful to these targets.
[...]
> Given my original patch is clean, and not harmful to existing targets
> support displaced stepping, please consider my original patch again.
> Comments on promising directions/approaches are welcome.
I haven't seen the patch, so I cannot comment specifically, but I think
that you are using the wrong reasons to try to justify your initial
patch. It does not matter whether sparc or hppa support displaced
stepping or not. They might - it's not far-fetched for sparc, for
instance. Or other platforms where it matters might be contributed
in the future, and they could need displaced stepping too. By letting
your patch in, we would be making it harder for other platforms to
implement it. It would feel like sweeping the dust under the carpet...
--
Joel
next prev parent reply other threads:[~2010-12-23 4:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 7:50 Yao Qi
2010-12-20 8:06 ` Mark Kettenis
2010-12-20 13:42 ` Yao Qi
2010-12-21 16:19 ` Yao Qi
2010-12-23 4:54 ` Joel Brobecker [this message]
2010-12-23 8:45 ` Yao Qi
2011-01-06 14:19 ` [PING : rfa] " Yao Qi
2011-01-12 5:39 ` [try 3rd] arm_pc_is_thumb takes displaced stepping into account Yao Qi
2011-01-13 15:55 ` Matthew Gretton-Dann
2011-01-13 16:34 ` Yao Qi
2011-01-19 16:09 ` [Ping 1: try " Yao Qi
2011-01-30 3:21 ` [Ping 2: " Yao Qi
2011-01-31 15:40 ` [try " Ulrich Weigand
2011-02-10 6:42 ` Yao Qi
2011-02-15 21:15 ` Ulrich Weigand
2010-12-23 12:04 ` [rfa] Update PC without side effect in displaced stepping Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223042236.GS2596@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox