From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6178 invoked by alias); 22 Dec 2010 22:02:14 -0000 Received: (qmail 6169 invoked by uid 22791); 22 Dec 2010 22:02:13 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate1.uk.ibm.com (HELO mtagate1.uk.ibm.com) (194.196.100.161) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Dec 2010 22:02:08 +0000 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate1.uk.ibm.com (8.13.1/8.13.1) with ESMTP id oBMM25kR013237 for ; Wed, 22 Dec 2010 22:02:05 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oBMM25pS3604616 for ; Wed, 22 Dec 2010 22:02:06 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oBMM23l0020967 for ; Wed, 22 Dec 2010 15:02:03 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id oBMM22Lg020960; Wed, 22 Dec 2010 15:02:02 -0700 Message-Id: <201012222202.oBMM22Lg020960@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 22 Dec 2010 23:02:02 +0100 Subject: Re: [patch 2/2] Implement gdbarch hook user_register_name on ARM To: yao@codesourcery.com (Yao Qi) Date: Thu, 23 Dec 2010 01:54:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <4D12288E.6030109@codesourcery.com> from "Yao Qi" at Dec 23, 2010 12:34:22 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00413.txt.bz2 Yao Qi wrote: > Good catch! set_gdbarch_deprecated_fp_regnum is called in > arm_gdbarch_init since 2003, introduced by this patch "Deprecate > TARGET_READ_FP, read_fp and FP_REGNUM" > http://sourceware.org/ml/gdb-patches/2003-04/msg00471.html > > set_gdbarch_deprecated_fp_regnum is no longer used in most of targets, > and I don't see any reason why we have to keep it in ARM, so I draft > this one-line patch. Huh, I didn't even see this, I was refering to this line: { "fp", 11 }, in arm_register_aliases. As long as this line is there, changes to set_gdbarch_deprecated_fp_regnum probably don't matter as this isn't even evaluated, since "fp" is just treated as a user register instead of a standard register. But you're right that you need to remove the set_gdbarch_deprecated_fp_regnum *also* in order to get the full default logic I had described. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com