From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28012 invoked by alias); 22 Dec 2010 12:29:09 -0000 Received: (qmail 28000 invoked by uid 22791); 22 Dec 2010 12:29:08 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Dec 2010 12:29:03 +0000 Received: (qmail 13715 invoked from network); 22 Dec 2010 12:29:02 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Dec 2010 12:29:02 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: Undefined uintptr_t with mingw Date: Wed, 22 Dec 2010 12:29:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; ) Cc: Joel Brobecker , Alberto Luaces , gdb-patches@sources.redhat.com References: <87k4j3krv3.fsf@eps142.cdf.udc.es> <20101222040005.GG2596@adacore.com> In-Reply-To: <20101222040005.GG2596@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201012221228.59906.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00395.txt.bz2 On Wednesday 22 December 2010 04:00:05, Joel Brobecker wrote: > [I changed the subject to include "gdbserver" in the subject] > > > diff -ur gdb-7.2orig/gdb/gdbserver/win32-low.c gdb-7.2/gdb/gdbserver/win32-low.c > > --- gdb-7.2orig/gdb/gdbserver/win32-low.c 2010-12-21 16:27:10.000000000 +0100 > > +++ gdb-7.2/gdb/gdbserver/win32-low.c 2010-12-21 17:21:56.000000000 +0100 > > @@ -33,6 +33,7 @@ > > #include > > #include > > #include > > +#include Odd that nobody reported this before. It kind of sounds like something's different on debian's mingw... ISTR that on mingw, stdint.h used to not be available. ISTR that's the reason we have the stdint.h inclusion in gdbserver/tracepoint.c guarded by HAVE_STDINT_H. Unless someone calls me mad, this is okay, with such a guard added. > Pedro is the current expert for gdbserver, so please wait for his > review, but I'm thinking that we should probably do the same as GDB, > which is include stdlib in the gdbserver equivalent of defs.h (i.e. > server.h). This is fine with me as well, but note that gdb/defs.h is including stdint.h unconditionally, because it can rely that gdb/gnulib provides one if the host doesn't have such a header, or if it finds the system one misses features. If we go this path, we should also wrap it in HAVE_STDINT_H. -- Pedro Alves From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28125 invoked by alias); 22 Dec 2010 12:29:09 -0000 Received: (qmail 28011 invoked by uid 22791); 22 Dec 2010 12:29:09 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Dec 2010 12:29:03 +0000 Received: (qmail 13715 invoked from network); 22 Dec 2010 12:29:02 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Dec 2010 12:29:02 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: Undefined uintptr_t with mingw Date: Wed, 22 Dec 2010 13:11:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; ) Cc: Joel Brobecker , Alberto Luaces , gdb-patches@sources.redhat.com References: <87k4j3krv3.fsf@eps142.cdf.udc.es> <20101222040005.GG2596@adacore.com> In-Reply-To: <20101222040005.GG2596@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-ID: <201012221228.59906.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00396.txt.bz2 Message-ID: <20101222131100.VQsO5xNf31PKJcoaA8Udt1TMP_W2IzIumVaiAqR576c@z> On Wednesday 22 December 2010 04:00:05, Joel Brobecker wrote: > [I changed the subject to include "gdbserver" in the subject] > > > diff -ur gdb-7.2orig/gdb/gdbserver/win32-low.c gdb-7.2/gdb/gdbserver/win32-low.c > > --- gdb-7.2orig/gdb/gdbserver/win32-low.c 2010-12-21 16:27:10.000000000 +0100 > > +++ gdb-7.2/gdb/gdbserver/win32-low.c 2010-12-21 17:21:56.000000000 +0100 > > @@ -33,6 +33,7 @@ > > #include > > #include > > #include > > +#include Odd that nobody reported this before. It kind of sounds like something's different on debian's mingw... ISTR that on mingw, stdint.h used to not be available. ISTR that's the reason we have the stdint.h inclusion in gdbserver/tracepoint.c guarded by HAVE_STDINT_H. Unless someone calls me mad, this is okay, with such a guard added. > Pedro is the current expert for gdbserver, so please wait for his > review, but I'm thinking that we should probably do the same as GDB, > which is include stdlib in the gdbserver equivalent of defs.h (i.e. > server.h). This is fine with me as well, but note that gdb/defs.h is including stdint.h unconditionally, because it can rely that gdb/gnulib provides one if the host doesn't have such a header, or if it finds the system one misses features. If we go this path, we should also wrap it in HAVE_STDINT_H. -- Pedro Alves