From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26842 invoked by alias); 21 Dec 2010 19:07:59 -0000 Received: (qmail 26833 invoked by uid 22791); 21 Dec 2010 19:07:57 -0000 X-SWARE-Spam-Status: No, hits=-0.4 required=5.0 tests=AWL,BAYES_20,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate1.uk.ibm.com (HELO mtagate1.uk.ibm.com) (194.196.100.161) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Dec 2010 19:07:52 +0000 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate1.uk.ibm.com (8.13.1/8.13.1) with ESMTP id oBLJ7m4B022821 for ; Tue, 21 Dec 2010 19:07:48 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oBLJ7oA83223572 for ; Tue, 21 Dec 2010 19:07:50 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oBLJ7lbT011860 for ; Tue, 21 Dec 2010 12:07:48 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id oBLJ7kiR011849; Tue, 21 Dec 2010 12:07:46 -0700 Message-Id: <201012211907.oBLJ7kiR011849@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 21 Dec 2010 20:07:46 +0100 Subject: Re: [patch 2/2] Implement gdbarch hook user_register_name on ARM To: yao@codesourcery.com (Yao Qi) Date: Tue, 21 Dec 2010 19:07:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <4D089CD6.5030500@codesourcery.com> from "Yao Qi" at Dec 15, 2010 06:47:50 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00382.txt.bz2 Yao Qi wrote: > On 12/15/2010 06:22 PM, Yao Qi wrote: > > Once this patch is applied, we leave more flexibility to backend to > > determine what is the correct register number given a register alias. > > This patch is to implement user_register_name on ARM. With this, we can > handle alias "fp" according to the current frame's mode (ARM or Thumb). > > Regression testing is still running on ARM. Comments are welcome. I'm wondering why the ARM back-end actively defines "fp" as user register anyway. If it simply were to *not* do so, GDB would fall back to the default implementation of $fp using value_of_builtin_frame_fp_reg, which seems to do always the correct thing anyway. It returns the value of the frame base as returned by arm_normal_frame_base, which will have been determined from r11 or r7 as appropriate for the mode. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com