From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22950 invoked by alias); 20 Dec 2010 03:09:06 -0000 Received: (qmail 22941 invoked by uid 22791); 20 Dec 2010 03:09:06 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Dec 2010 03:09:01 +0000 Received: (qmail 12098 invoked from network); 20 Dec 2010 03:08:59 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Dec 2010 03:08:59 -0000 Date: Mon, 20 Dec 2010 03:09:00 -0000 From: Daniel Jacobowitz To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [patch, arm] Consistent display of registers in corefile Message-ID: <20101220030856.GG7961@caradoc.them.org> References: <4D022D1A.7030701@codesourcery.com> <201012101443.oBAEhFiT023638@glazunov.sibelius.xs4all.nl> <20101213025718.GA4731@caradoc.them.org> <4D05EEC0.7030200@codesourcery.com> <20101219182358.GA7961@caradoc.them.org> <4D0EBF7B.7050807@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D0EBF7B.7050807@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00360.txt.bz2 On Mon, Dec 20, 2010 at 10:29:15AM +0800, Yao Qi wrote: > Do you have comments to arm_fps_group.patch, which fixes the 2nd problem > I pointed out in [1]? In short, this fix will make GDB treat fps > register as registers in float group, fps will disappear in output of > "info register". > > gdb/ > * arm-tdep.c (arm_register_reggroup_p): New. > (arm_gdbarch_init): Set arm_register_reggroup_p for hook > register_reggroup_p. > > arm_fps_group.patch is the 2nd patch I attached in [1]. > > [1] http://sourceware.org/ml/gdb-patches/2010-12/msg00134.html That looks OK to me. -- Daniel Jacobowitz CodeSourcery