From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31323 invoked by alias); 17 Dec 2010 21:40:25 -0000 Received: (qmail 31310 invoked by uid 22791); 17 Dec 2010 21:40:24 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Dec 2010 21:40:20 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBHLeIJD022487 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 17 Dec 2010 16:40:18 -0500 Received: from mesquite.lan ([10.3.113.8]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oBHLeHdE017549 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Fri, 17 Dec 2010 16:40:17 -0500 Date: Fri, 17 Dec 2010 21:40:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [RFC] mips-tdep.c: Fix mips16 bit rot Message-ID: <20101217144016.739acc86@mesquite.lan> In-Reply-To: <20101213170635.6f0c4356@mesquite.lan> References: <20101213170635.6f0c4356@mesquite.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00349.txt.bz2 On Mon, 13 Dec 2010 17:06:35 -0700 Kevin Buettner wrote: > * mips-tdep.c (make_mips16_addr): New function. > (mips_elf_make_msymbol_special): Don't set the low bit in the > symbol's address. > (mips_read_pc, mips_unwind_pc, mips_addr_bits_remove): Strip bit > indicating mips16 address, if present. > (mips_write_pc): Set bit indicating mips16 address when in a mips16 > function. > (mips_eabi_push_dummy_call, mips_o64_push_dummy_call): Likewise, > but for each function pointer argument to inferior function call. Committed. Kevin