From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27162 invoked by alias); 15 Dec 2010 19:40:02 -0000 Received: (qmail 27146 invoked by uid 22791); 15 Dec 2010 19:40:02 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Dec 2010 19:39:57 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id B33721B4117; Wed, 15 Dec 2010 19:39:55 +0000 (UTC) From: Mike Frysinger To: Pedro Alves Subject: Re: [PATCH v4] gdb: bfin: new port Date: Wed, 15 Dec 2010 19:40:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.37-rc5; KDE/4.5.2; x86_64; ; ) Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org References: <1292431646-3744-1-git-send-email-vapier@gentoo.org> <201012151917.03834.pedro@codesourcery.com> In-Reply-To: <201012151917.03834.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1377718.fLZ6y6BIY9"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201012151439.03130.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00319.txt.bz2 --nextPart1377718.fLZ6y6BIY9 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 1334 On Wednesday, December 15, 2010 14:17:03 Pedro Alves wrote: > On Wednesday 15 December 2010 16:47:25, Mike Frysinger wrote: > > +bfin-*-*) > > + # Target: Blackfin > > + gdb_target_obs=3D"bfin-tdep.o bfin-linux-tdep.o linux-tdep.o" > > + ;; >=20 > should probably be: >=20 > bfin-*-uclinux*) > # Target: Blackfin running uclinux > gdb_target_obs=3D"bfin-tdep.o bfin-linux-tdep.o linux-tdep.o" > ;; > bfin-*-*) > # Target: Blackfin > gdb_target_obs=3D"bfin-tdep.o" > ;; >=20 > The top-level src/configure.ac seems to actually use > bfin*-*-uclinux* (extra star). we run Linux. uClinux is an old naming. also, bfin-linux-uclibc is a=20 supported target, so i tend to use bfin-*-*linux*. in the past, any Blackfin gdb was sufficient to debug any Blackfin target, = but=20 i guess i could preserve this with --enable-targets=3D... ? > > + warning (_("Function Prologue not recognised; pc will point to > > ENTRY_POINT of the function")); >=20 > way too long line. write as, e.g., >=20 > warning (_("Function Prologue not recognised; " > "pc will point to ENTRY_POINT of the function")); yes it's long, but i thought the emphasis was on not breaking string litera= ls.=20=20 screws up grep and such. the rest i've fixed locally -mike --nextPart1377718.fLZ6y6BIY9 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iQIcBAABAgAGBQJNCRlXAAoJEEFjO5/oN/WBY3kP/1kI1GZx6J2fh4p5GNj6e0Tz Osa7un+x19Nhr4r/P864fs4CusmefjfW4p6UdpQrSlvVm7IAbnfUGQWgz+okTxM4 ZtSkCR4Ajv1PezBI59VJqcezpatuEeSp171N9NEQGCHBROIOv6vnG3j1ZElLAnxf mjoCYczL3HsyxgZfmA+pLR3eD1oeS4RVbFKhqoyI8gbyGu7QM6ZYhwSDYVkHQ2V2 Qj4DMQDpAuWooI5OqWoJrEi+b1RR+1yddoHpXM5IXeVHjp7X3FpRnvKQ1Z/Z3P2r WTmDc1ThSxv469phUidCXOhkT1WwCgy4hCMsFUy35eqxag6tRlPaAHnICWgaMsUG LsVJLHn8kBUOc2w/fkeoGQIfoTBwsErOncGzIgvmFVxs2ZoZjiP+P78GGNJ27jjT Hg+so03bK2uVwC34OgJjwnTiZIF5ByA0lvcX8Fd1cbNG6kY8EM345LhNtoO4wO/v pxJJhIEjoImvpSjUOg/VI+U47N8FRY8+B8ufvpjeYyZYZUkI9IlcxOfpcj5vphNy E7GyXqLi9Li8fzgV5zMe0KPdeWq/TUhKK5YmqkJe7GoMfpTtxxW08LDSd04pGInL xrlFpl2GYJ5nGKa1B2n2HzHPeMz7X4tPIH0ay7QW8wJtBEi2WTJS/fjNynXkewzi iN7MlPwvq8m/wmHutw+a =72qG -----END PGP SIGNATURE----- --nextPart1377718.fLZ6y6BIY9--