From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21879 invoked by alias); 15 Dec 2010 05:07:21 -0000 Received: (qmail 21861 invoked by uid 22791); 15 Dec 2010 05:07:20 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Dec 2010 05:07:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5D1002BAB5B; Wed, 15 Dec 2010 00:07:14 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id aAY8n+HQgtqJ; Wed, 15 Dec 2010 00:07:14 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D74492BAB5A; Wed, 15 Dec 2010 00:07:13 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 6C10A145B58; Wed, 15 Dec 2010 06:07:00 +0100 (CET) Date: Wed, 15 Dec 2010 05:07:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: Ken Werner , gdb-patches@sourceware.org Subject: Re: [patch, libiberty, gdb] IEEE 754 half floating-point format Message-ID: <20101215050700.GY2596@adacore.com> References: <20101118174427.GG2634@adacore.com> <201012141610.oBEGA5r2029793@d06av02.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201012141610.oBEGA5r2029793@d06av02.portsmouth.uk.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00278.txt.bz2 > > My only comment regarding this part of the patch is that "half_bit" > > and "half_format" isn't very intuitive. Perhaps that's more obvious > > to someone who programs in OpenCL if "half" is a type name? For > > the other arch routines, the routine name makes it clear that it's > > about floating point types, because it contains a name that is > > clearly associated to floats (float, double, long double). What > > about using "half_float_bit" and "half_float_format"? [...] > Of course, we could still change the name of the gdbarch callbacks > if you think this would be more intuitive. No one really commented on it, so it's probably not worth our trouble, I think. -- Joel