From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10482 invoked by alias); 14 Dec 2010 18:06:56 -0000 Received: (qmail 10472 invoked by uid 22791); 14 Dec 2010 18:06:54 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Dec 2010 18:06:49 +0000 Received: (qmail 7815 invoked from network); 14 Dec 2010 18:06:47 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Dec 2010 18:06:47 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdbserver: bfin: new port Date: Tue, 14 Dec 2010 18:06:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; ) Cc: Mike Frysinger , Andrew Stubbs , toolchain-devel@blackfin.uclinux.org, Daniel Jacobowitz References: <1291886957-12003-1-git-send-email-vapier@gentoo.org> <201012141739.52716.pedro@codesourcery.com> <201012141247.12591.vapier@gentoo.org> In-Reply-To: <201012141247.12591.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201012141806.44803.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00252.txt.bz2 On Tuesday 14 December 2010 17:47:11, Mike Frysinger wrote: > > I think that's the best approach. Would it be easy to split > > the linux bits out of gdb/bfin-tdep.c into gdb/bfin-linux-tdep.c? > > You could even push the bare metal (bfin-elf?) bits first without > > any linux bits as a first step. > > i imagine for someone who is a gdb expert, this would be trivial. but it > would require a bit of research on my side, so i'd prefer to not do this > initially. the code Joel is OK with supports both Blackfin bare metal and > Blackfin Linux/FLAT. Okay. > > i'll open a tracker item to get this stuff eventually split out, but i dont > see it being done in a time frame that is before the gdb-7.3 release which i > really want to be a part of. That's months away. I think you're over estimating. :-) > > > Please also get rid of gdb/config/bfin/bfin.mt -- .mt files have > > long since been eliminated from gdb, the code that would go there you > > already have in configure.tgt. > > i couldnt find documentation on this file (or mts in general) so i was > hesitant to touch it. the only thing we have in there is to set the TDEPFILES > variable, but i guess that too is no longer used anywhere ? Correct. Those sets of TDEPFILES in .mt files got migrated to configure.tgt where you now set gdb_target_obs (as you already have, your .mt file in the patch is empty). BTW, you should also include linux-tdep.o in gdb_target_obs, and call linux_init_abi somewhere in your GDB_OSABI_LINUX osabi handler. -- Pedro Alves