From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19382 invoked by alias); 14 Dec 2010 16:10:19 -0000 Received: (qmail 19370 invoked by uid 22791); 14 Dec 2010 16:10:15 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate4.uk.ibm.com (HELO mtagate4.uk.ibm.com) (194.196.100.164) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Dec 2010 16:10:10 +0000 Received: from d06nrmr1307.portsmouth.uk.ibm.com (d06nrmr1307.portsmouth.uk.ibm.com [9.149.38.129]) by mtagate4.uk.ibm.com (8.13.1/8.13.1) with ESMTP id oBEGA7H4014552 for ; Tue, 14 Dec 2010 16:10:07 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oBEGA8o72908348 for ; Tue, 14 Dec 2010 16:10:08 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oBEGA6eg029809 for ; Tue, 14 Dec 2010 09:10:06 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id oBEGA5r2029793; Tue, 14 Dec 2010 09:10:05 -0700 Message-Id: <201012141610.oBEGA5r2029793@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 14 Dec 2010 17:10:05 +0100 Subject: Re: [patch, libiberty, gdb] IEEE 754 half floating-point format To: brobecker@adacore.com (Joel Brobecker) Date: Tue, 14 Dec 2010 16:10:00 -0000 From: "Ulrich Weigand" Cc: ken@linux.vnet.ibm.com (Ken Werner), gdb-patches@sourceware.org In-Reply-To: <20101118174427.GG2634@adacore.com> from "Joel Brobecker" at Nov 18, 2010 09:44:27 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00232.txt.bz2 Joel Brobecker wrote: > > include/ChangeLog: > > > > 2010-07-02 Ken Werner > > > > * gfloatformat.h (floatformat_ieee_half_big): Add declaration. > ^^^ typo > > (floatformat_ieee_half_little): Likewise. > > > > libiberty/ChangeLog: > > > > 2010-07-02 Ken Werner > > > > * floatformat.c (floatformat_ieee_half_big): New variable. > > (floatformat_ieee_half_little): Likewise. > > This part should be submitted to GCC, I think? > > > 2010-07-02 Ken Werner > > > > * gdbtypes.h (floatformats_ieee_half): Add declaration. > > * gdbtypes.c (floatformats_ieee_half): New variable. > > * doublest.c (floatformat_from_length): Set format to > > gdbarch_half_format if length matches. > > * gdbarch.sh (half_bit): New architecture method. > > (half_format): Likewise. > > * gdbarch.h: Regenerate. > > * gdbarch.c: Likewise. > > My only comment regarding this part of the patch is that "half_bit" > and "half_format" isn't very intuitive. Perhaps that's more obvious > to someone who programs in OpenCL if "half" is a type name? For > the other arch routines, the routine name makes it clear that it's > about floating point types, because it contains a name that is > clearly associated to floats (float, double, long double). What > about using "half_float_bit" and "half_float_format"? > > What do others think? Note that I had already approved this patch back in July, after the libiberty part was approved by DJ Delorie, so everything is already committed ... Of course, we could still change the name of the gdbarch callbacks if you think this would be more intuitive. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com