From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24929 invoked by alias); 14 Dec 2010 18:34:02 -0000 Received: (qmail 24904 invoked by uid 22791); 14 Dec 2010 18:33:59 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Dec 2010 18:33:55 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 568011B400D; Tue, 14 Dec 2010 18:33:52 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: add --map-info option Date: Tue, 14 Dec 2010 18:34:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.37-rc5; KDE/4.5.2; x86_64; ; ) Cc: Joel Brobecker , Stephen.Kilbane@analog.com, Stuart.Henderson@analog.com, David.Gibson@analog.com References: <1291219863-18458-1-git-send-email-vapier@gentoo.org> <20101214073558.GS2596@adacore.com> <201012141016.23030.vapier@gentoo.org> In-Reply-To: <201012141016.23030.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1712900.RUvcFW63mh"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201012141333.11297.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00254.txt.bz2 --nextPart1712900.RUvcFW63mh Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 1278 On Tuesday, December 14, 2010 10:16:21 Mike Frysinger wrote: > On Tuesday, December 14, 2010 02:35:58 Joel Brobecker wrote: > > How about: > >=20=20=20=20=20 > > char * > > io_map_to_str (unsigned nr_map) > > { >=20 > but this idea is good, so i'll implement it ah, someone already beat us to it. there's a map_to_str() func. > > > + sim_io_printf (sd, " map "); > > > + if (mapping->space !=3D 0) > > > + sim_io_printf (sd, "0x%lx:", (long) mapping->space); > > > + sim_io_printf (sd, "0x%08lx", (long) mapping->base); > > > + if (mapping->level !=3D 0) > > > + sim_io_printf (sd, "@0x%lx", (long) mapping->level); > > > + sim_io_printf (sd, ",0x%lx", (long) mapping->nr_bytes); > > > + modulo =3D mapping->mask + 1; > > > + if (modulo !=3D 0) > > > + sim_io_printf (sd, "%%0x%lx", (long) modulo); > >=20 > > I don't understand the necessity to cast everything to long. Can you > > explain? >=20 > it's taken largely unchanged from the OPTION_MEMORY_INFO case block just > above my new block. i guess my new code could review the types and do it > right. ok, some of the (long) casts are necessary. specifically, the ones who hav= e a=20 type of "unsigned_word" as those depend on the target bitness (which could = be=20 16, 32, or 64). -mike --nextPart1712900.RUvcFW63mh Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iQIcBAABAgAGBQJNB7hnAAoJEEFjO5/oN/WBTUoP/RYuw+c8arN5uKZvIqFiuPdE M8GbqCjuAjOcEB7oP14O/VPkBpRaksQU0QEbDHpoNou4VEbt6YRXAHjjHvce4u+I lP5OZC6FqvPrC8y1Lrsbj5DVwnAOtusNMnAYc8kiPXZNs72mLtcIDDwhx4eA8u0r YcENJPKV4tuqAb3gx41mkcqELcCzN5u+ay566yrLRe7kIuHb1HjPY8Pf4CZXNkcB hVfVRkO9bxmUkaqAV/wX0g6Ogbx+nTfTtRaKV5t5zf20+X3Vu9xsUke+aLJ8ha0x WWkKwyoEAAzIxhwcgAAzpPecZroThyAC4Eq8OKDJX9ne95Bz0zK8rtYR4ME94h/P 5dAeHRehaul9TaXnvRMFTdIJ0RuPL5pb7DXJfx+Iei8FTBqJE91+9s0mFm5b6VDW pTd7Olr8oBFJwmyUWYRVj6aXDf2xD+xq8z4oSjclxYgB9l6aeUtbjzlefbIlqskT kZ9jxOLYm7Lei1yCZ48aWgc3MgrP7w0Cp6F9CIDHduvsacukd7lKlecne4P1C14O VYPL8m2iM7Zak3bDKI9vSBLQ7JDBT9O2Ue6YkX4QKhvDwT087xPVKdWVONy438Gw llLXo3fyTfrfIr4cIXYXaiaNFFDxXy2bABiZJZL6gan8jqEUO/puWSm64mPNKjx8 ThoIXfrAZxp1w2cEr1qc =Y8G9 -----END PGP SIGNATURE----- --nextPart1712900.RUvcFW63mh--