From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22893 invoked by alias); 14 Dec 2010 16:14:53 -0000 Received: (qmail 22882 invoked by uid 22791); 14 Dec 2010 16:14:52 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Dec 2010 16:14:45 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id AE2581B41CC; Tue, 14 Dec 2010 16:14:43 +0000 (UTC) From: Mike Frysinger To: Joel Brobecker Subject: Re: [PATCH v2] gdb: bfin: new port Date: Tue, 14 Dec 2010 16:14:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.37-rc5; KDE/4.5.2; x86_64; ; ) Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org References: <1291886957-12003-1-git-send-email-vapier@gentoo.org> <20101214060247.GK2596@adacore.com> In-Reply-To: <20101214060247.GK2596@adacore.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1320392.OUoOxURFaS"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201012141114.03853.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00234.txt.bz2 --nextPart1320392.OUoOxURFaS Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1639 On Tuesday, December 14, 2010 01:02:47 Joel Brobecker wrote: > > 2010-11-16 Jie Zhang > >=20 > > * Makefile.in (ALLDEPFILES): Add bfin-tdep.c. > > (HFILES_NO_SRCDIR): Add bfin-tdep.h. >=20 > (ALL_TARGET_OBS): Add bfin-tdep.o >=20 > > * NEWS: Mention new Blackfin port. > > * bfin-tdep.c, bfin-tdep.h, config/bfin/bfin.mt: New files. > > * configure.tgt (bfin-*-*): Handle bfin targets. >=20 > The syscall file is also missing. ugh, sorry about that. when i was squashing changesets in git, i forgot to= =20 merge the changelogs too. > There are a couple of nits, highlighted below. But the patch is > pre-approved with those nits fixed as suggested. One little issue, > though: Please make sure that Eli reviews the change in the NEWS > file before checking in that part of the patch (it can be done > separately). Eli approved the changes as found in the original patch, and they are=20 unchanged in this version, so i think that should be sufficient. > > +#ifdef _DEBUG > > + fprintf (stderr, "frameless pc case base %x\n", cache->base); > > +#endif >=20 > You forgot to remove the #ifdef DEBUG block... indeed. i went through your original feedback again to make sure i didnt m= iss=20 anything else, and this seems to be the only one. > > +/* Return the Blackfin ABI associated with GDBARCH. */ > > +static inline enum bfin_abi > > +bfin_abi (struct gdbarch *gdbarch) > > +{ > > + return gdbarch_tdep (gdbarch)->bfin_abi; > > +} >=20 > Please define that function in bfin-tdep.c, and put a declaration in > bfin-tdep.h instead. ah, i see what you mean now in your previous feedback -mike --nextPart1320392.OUoOxURFaS Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iQIcBAABAgAGBQJNB5fLAAoJEEFjO5/oN/WBXVgP/1Dc0j5aYyh42StR/o1cO/cw UvyGrKf6DoJ2+rOKxWjaAmWaCdaF5/2ajZsmGnO/Dv5iOow/ofKK4nM47gFQeb7m DkdJZ2T4JLYOG00BvvwX15zGxaJezRDYmlwDcbcEi5Ua3zdGfX9BbMDkOlIfAhwZ gzul+/nRq5ZO9Bor/gbSbE9MLY2N1KczGGUYhYt8PyXhXhZm37xLh3g+nSICdziq qUHBbnYISy03iSL5gjbxrNkuQ9oT7A10dP4F/+UkauEE+zeh8ABhBEt20pZL1X0O miLwae/WSFkdxkM2tnX4ALZ85qlmsDdYS/nzq5Ja5Zgd8vP18uK923icb+VW1kHN KSp28B3CjxEAbm+z8zHm+OuwKAoNr2jmdP/r+2kOcpHaeHVED3OHeYFBpuqCPTG/ OK1JPdgv3PM28vC5Fhb+wShIQvPFOV+svCZH712ai0pbZEiHGaMNxMmxGOj9eaa1 PS4Agou+tIFZsnHZgu4i71yrrHGAUWsOL/IIU1P58p8zylqk05CDOzl62XFv2Z7d h9deL8RIWEWChomJZ3Y98ocD8IaShzJYCJCp/7zO65J/PAzOfUd4BeZ36pfC8dS+ wBxXyQmSys4OyC7IlYe+AnacC3FaD1k0mjsNqnpHvViqfxFPE8SxmHXIw9fjHVCN F9uYpDHBP57U1KW2kKgK =m5Ek -----END PGP SIGNATURE----- --nextPart1320392.OUoOxURFaS--