From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20197 invoked by alias); 14 Dec 2010 06:03:07 -0000 Received: (qmail 20187 invoked by uid 22791); 14 Dec 2010 06:03:05 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Dec 2010 06:03:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DECC72BAB6E; Tue, 14 Dec 2010 01:02:59 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id nFME7Nv8xwVQ; Tue, 14 Dec 2010 01:02:59 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 422B52BAB3F; Tue, 14 Dec 2010 01:02:59 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 84624145B58; Tue, 14 Dec 2010 07:02:47 +0100 (CET) Date: Tue, 14 Dec 2010 06:03:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org, Jie Zhang Subject: Re: [PATCH v2] gdb: bfin: new port Message-ID: <20101214060247.GK2596@adacore.com> References: <1291886957-12003-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1291886957-12003-1-git-send-email-vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00208.txt.bz2 > 2010-11-16 Jie Zhang > > * Makefile.in (ALLDEPFILES): Add bfin-tdep.c. > (HFILES_NO_SRCDIR): Add bfin-tdep.h. (ALL_TARGET_OBS): Add bfin-tdep.o > * NEWS: Mention new Blackfin port. > * bfin-tdep.c, bfin-tdep.h, config/bfin/bfin.mt: New files. > * configure.tgt (bfin-*-*): Handle bfin targets. The syscall file is also missing. There are a couple of nits, highlighted below. But the patch is pre-approved with those nits fixed as suggested. One little issue, though: Please make sure that Eli reviews the change in the NEWS file before checking in that part of the patch (it can be done separately). > +#ifdef _DEBUG > + fprintf (stderr, "frameless pc case base %x\n", cache->base); > +#endif You forgot to remove the #ifdef DEBUG block... > +/* Return the Blackfin ABI associated with GDBARCH. */ > +static inline enum bfin_abi > +bfin_abi (struct gdbarch *gdbarch) > +{ > + return gdbarch_tdep (gdbarch)->bfin_abi; > +} Please define that function in bfin-tdep.c, and put a declaration in bfin-tdep.h instead. -- Joel