From: Joel Brobecker <brobecker@adacore.com>
To: Ken Werner <ken@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: [patch] DW_AT_byte_size for array type entries
Date: Tue, 14 Dec 2010 05:42:00 -0000 [thread overview]
Message-ID: <20101214054150.GJ2596@adacore.com> (raw)
In-Reply-To: <201012132103.09320.ken@linux.vnet.ibm.com>
> 2010-12-13 Ken Werner <ken.werner@de.ibm.com>
>
> * valops.c (value_one): Use get_array_bounds to compute the number
> of array elements instead of dividing the length of the array by the
> length of the element types.
> * valarith.c (value_complement, value_neg): Likewise.
This is OK.
As a followup patch, how about defining a new function `get_array_length'
next to get_array_bounds? That way, you can factorize of this code that
keeps being repeated...
--
Joel
next prev parent reply other threads:[~2010-12-14 5:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 11:24 Ken Werner
2010-10-19 18:16 ` Ken Werner
2010-11-02 8:23 ` Ken Werner
2010-11-02 22:45 ` Tom Tromey
2010-11-03 14:23 ` Ken Werner
2010-11-03 19:09 ` Regression on gdb.ada/null_array.exp [Re: [patch] DW_AT_byte_size for array type entries] Jan Kratochvil
2010-11-03 21:16 ` Joel Brobecker
2010-11-03 23:22 ` [commit/Ada] fix warning when printing empty array Joel Brobecker
2010-11-03 23:24 ` Regression on gdb.ada/null_array.exp [Re: [patch] DW_AT_byte_size for array type entries] Joel Brobecker
2010-11-04 0:31 ` Jan Kratochvil
2010-11-04 1:57 ` Joel Brobecker
2010-11-04 3:26 ` Jan Kratochvil
2010-11-04 18:01 ` Joel Brobecker
2010-11-04 18:10 ` Jan Kratochvil
2010-11-04 18:23 ` Joel Brobecker
2010-11-04 18:54 ` Jan Kratochvil
2010-11-04 22:11 ` Joel Brobecker
2010-12-13 20:03 ` [patch] DW_AT_byte_size for array type entries Ken Werner
2010-12-14 5:42 ` Joel Brobecker [this message]
2010-12-14 10:27 ` Ken Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101214054150.GJ2596@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ken@linux.vnet.ibm.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox