Re: [PATCH v2] gdbserver: bfin: new port

[Pedro Alves <pedro@codesourcery.com>]

>  /* Under uClinux, programs are loaded at non-zero offsets, which we need
> diff --git a/gdb/regformats/reg-bfin.dat b/gdb/regformats/reg-bfin.dat
> new file mode 100644
> index 0000000..38dca22
> --- /dev/null
> +++ b/gdb/regformats/reg-bfin.dat
> @@ -0,0 +1,63 @@
> +name:bfin
> +expedite:pc,sp,fp
> +32:r0
> +32:r1
> +32:r2
> +32:r3
> +32:r4
> +32:r5
> +32:r6
> +32:r7
> +32:p0
> +32:p1
> +32:p2
> +32:p3
> +32:p4
> +32:p5
> +32:sp
> +32:fp
> +32:i0
> +32:i1
> +32:i2
> +32:i3
> +32:m0
> +32:m1
> +32:m2
> +32:m3
> +32:b0
> +32:b1
> +32:b2
> +32:b3
> +32:l0
> +32:l1
> +32:l2
> +32:l3
> +32:a0x
> +32:a0w
> +32:a1x
> +32:a1w
> +32:astat
> +32:rets
> +32:lc0
> +32:lt0
> +32:lb0
> +32:lc1
> +32:lt1
> +32:lb1
> +32:cycles
> +32:cycles2
> +32:usp
> +32:seqstat
> +32:syscfg
> +32:reti
> +32:retx
> +32:retn
> +32:rete
> +32:pc
> +32:cc

> +32:text_addr
> +32:text_end_addr
> +32:data_addr
> +32:fdpic_exec
> +32:fdpic_interp
> +32:ipend

Hmmm.  These last 6 look to be some kind of pseudo registers, not
part of the ISA -- I'm quite surprised to see these here, as
part of the bfin core register set.  I understand these to be
fdpic related; ISTR some discussion about making these be reported
with a new qXfer object?  That'd be better, IMO.

I haven't looked at any bfin docs, but if any of the other
registers aren't core registers (only available in some variants), you
should consider implementing xml target register descriptions.

-- 
Pedro Alves