From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76943-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10763 invoked by alias); 13 Dec 2010 15:39:31 -0000
Received: (qmail 10755 invoked by uid 22791); 13 Dec 2010 15:39:30 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Dec 2010 15:39:26 +0000
Received: (qmail 1276 invoked from network); 13 Dec 2010 15:39:24 -0000
Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 13 Dec 2010 15:39:24 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch, testsuite] General ARM target triplet
Date: Mon, 13 Dec 2010 15:39:00 -0000
User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; )
Cc: Yao Qi <yao@codesourcery.com>, Andreas Schwab <schwab@linux-m68k.org>, Richard Earnshaw <rearnsha@arm.com>, "Joseph S. Myers" <joseph@codesourcery.com>
References: <4CF91BD4.7090708@codesourcery.com> <201012131407.08185.pedro@codesourcery.com> <4D063BA8.4000404@codesourcery.com>
In-Reply-To: <4D063BA8.4000404@codesourcery.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201012131539.22392.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-12/txt/msg00188.txt.bz2

On Monday 13 December 2010 15:28:40, Yao Qi wrote:
> On 12/13/2010 10:07 PM, Pedro Alves wrote:
> >> The second sentence is removed by this (2nd) patch, which depends on the
> >> first patch.
> > 
> > I think it would have been easier if you had just posted this as
> > an updated version of the first patch.
> > 
> 
> OK, I combine them together in one single patch this time.

Thanks.  If/when everyone's happy with the triplet bits
proper, this is okay.

> 
> >> diff --git a/gdb/testsuite/gdb.python/py-section-script.exp b/gdb/testsuite/gdb.python/py-section-script.exp
> >> index 434dca4..373c450 100644
> >> --- a/gdb/testsuite/gdb.python/py-section-script.exp
> >> +++ b/gdb/testsuite/gdb.python/py-section-script.exp
> >> @@ -17,7 +17,6 @@
> >>  # scripts specified in the .debug_gdb_scripts section.
> >>  
> >>  # This test can only be run on targets which support ELF and use gas.
> >> -# For now pick a sampling of likely targets.
> >>  if {![istarget *-*-linux*]
> >>      && ![istarget *-*-gnu*]
> >>      && ![istarget *-*-elf*]
> > 
> > If the "support ELF" comment is correct (as opposed to "support DWARF-2" in
> > the other cases), then you should not remove this one.
> > 
> 
> Done.
> 
> > Back in the first patch:
> > 
> > On Sunday 05 December 2010 12:15:09, Yao Qi wrote:
> >> +# This test can only be run on targets which support DWARF-2 and use gas.
> >> +proc dwarf2_support {} {
> > 
> > There's no "This test" anymore.  Maybe:
> > 
> > # Return true if the target supports DWARF-2 and uses gas.
> > # For now pick a sampling of likely targets.
> 
> Fixed.
> 
> 


-- 
Pedro Alves