From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19859 invoked by alias); 7 Dec 2010 07:41:10 -0000 Received: (qmail 19851 invoked by uid 22791); 7 Dec 2010 07:41:09 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Dec 2010 07:41:03 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oB77f11d015438 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 7 Dec 2010 02:41:02 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oB77evew028591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 7 Dec 2010 02:41:00 -0500 Received: from host0.dyn.jankratochvil.net (host0.dyn.jankratochvil.net [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id oB77eu4H001612; Tue, 7 Dec 2010 08:40:56 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id oB77etwh001611; Tue, 7 Dec 2010 08:40:55 +0100 Date: Tue, 07 Dec 2010 07:41:00 -0000 From: Jan Kratochvil To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Limit attempts to place breakpoints on _start, __start, and main in solib-svr4.c Message-ID: <20101207074055.GA1257@host0.dyn.jankratochvil.net> References: <20101129160233.1265d555@mesquite.lan> <20101130000707.GA26969@host0.dyn.jankratochvil.net> <20101130180618.66003c99@mesquite.lan> <20101201230339.GA8453@host0.dyn.jankratochvil.net> <20101203140433.69c17fc4@mesquite.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101203140433.69c17fc4@mesquite.lan> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00068.txt.bz2 Hi Kevin, On Fri, 03 Dec 2010 22:04:33 +0100, Kevin Buettner wrote: > We do want to (potentially) attempt to place the breakpoints on > _start, __start, and main in case 1, but not for case 2 and 3. if this functionality change is enough for now this patch looks safe to me. > The patch below won't necessarily work correctly with stubs which do > not implement the qAttached packet. (gdbserver does implement > qAttached.) My reading of remote.c indicates that stubs which do > not implement "qAttached" will end up causing attach_flag to be 0. Therefore it also falls back to the current/safe mode in such case. > Further comments? > * solib-svr4.c (enable_break): Don't attempt to place breakpoints, > when attaching, on the names in bkpt_names: _start, __start, and > main. As Mark also agrees with this patch I find it OK for the check-in. Thanks, Jan