From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30503 invoked by alias); 4 Dec 2012 06:09:51 -0000 Received: (qmail 30492 invoked by uid 22791); 4 Dec 2012 06:09:50 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,GENERIC_IXHASH,KHOP_RCVD_UNTRUST,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mailout1.samsung.com (HELO mailout1.samsung.com) (203.254.224.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Dec 2012 06:09:41 +0000 Received: from epcpsbge8.samsung.com (epcpsbge8 [203.254.230.18]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MEH00KQJT2OHV60@mailout1.samsung.com> for gdb-patches@sourceware.org; Tue, 04 Dec 2012 15:09:30 +0900 (KST) Received: from epcpsbge8.samsung.com ( [172.20.52.124]) by epcpsbge8.samsung.com (EPCPMTA) with SMTP id 30.82.12847.A939DB05; Tue, 04 Dec 2012 15:09:30 +0900 (KST) Received: from epextmailer03 ( [203.254.219.153]) by epcpsbge8.samsung.com (EPCPMTA) with SMTP id 00.82.12847.A939DB05; Tue, 04 Dec 2012 15:09:30 +0900 (KST) Date: Tue, 04 Dec 2012 06:09:00 -0000 From: KARTHIKVENKATESH BHAT Subject: Re: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary To: Mark Kettenis , KARTHIKVENKATESH BHAT Cc: "palves@redhat.com" , "gdb-patches@sourceware.org" , tromey@redhat.com Reply-to: kv.bhat@samsung.com MIME-version: 1.0 X-MTR: 20121204051049671@kv.bhat Msgkey: 20121204051049671@kv.bhat X-EPLocale: en_US.windows-1252 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-EPTrCode: X-EPTrName: X-MLAttribute: X-RootMTR: 20121204051049671@kv.bhat X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N Content-transfer-encoding: base64 Content-type: text/plain; charset=windows-1252 MIME-version: 1.0 Message-id: <20101179.243591354601368727.JavaMail.weblogic@epml08> DLP-Filter: Pass X-CFilter-Loop: Reflected Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00054.txt.bz2 SGkgTWFyay9Ub20vUGFsdmVzLA0KVGhhbmtzIGZvciB0YWtpbmcgeW91ciB0 aW1lIG91dCBmb3IgcmV2aWV3Lg0KSSBoYXZlIGltcGxlbWVudGVkIHRoZSBy ZXZpZXcgY29tbWVudHMuIFBsZWFzZSBsZXQgbWUga25vdyBpZiBpIGNhbiBj b21taXQgdGhlIHNhbWUuDQoNCmN2cyBkaWZmOiBEaWZmaW5nIC4NCkluZGV4 OiBDaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxl OiAvY3ZzL3NyYy9zcmMvZ2RiL0NoYW5nZUxvZyx2DQpyZXRyaWV2aW5nIHJl dmlzaW9uIDEuMTQ4ODANCmRpZmYgLXUgLXAgLXIxLjE0ODgwIENoYW5nZUxv Zw0KLS0tIENoYW5nZUxvZwkzIERlYyAyMDEyIDIyOjMxOjAyIC0wMDAwCTEu MTQ4ODANCisrKyBDaGFuZ2VMb2cJNCBEZWMgMjAxMiAwNTowNjoyOSAtMDAw MA0KQEAgLTEsMyArMSwxMCBAQA0KKzIwMTItMTItMDQgIEthcnRoaWsgQmhh dCAgPGt2LmJoYXRAc2Ftc3VuZy5jb20+DQorDQorCSogaTM4Ni10ZGVwLmMg KGkzODZfc2tpcF9wcm9sb2d1ZSk6IFVzaW5nIHN5bWJvbCB0YWJsZQ0KKwl0 byBmaW5kIHRoZSBlbmQgb2YgcHJvbG9ndWUgZm9yIGNsYW5nIGNvbXBpbGVk IGJpbmFyaWVzLg0KKwkqIGFtZDY0LXRkZXAuYyAoYW1kNjRfc2tpcF9wcm9s b2d1ZSk6VXNpbmcgc3ltYm9sIHRhYmxlDQorCXRvIGZpbmQgdGhlIGVuZCBv ZiBwcm9sb2d1ZSBmb3IgY2xhbmcgY29tcGlsZWQgYmluYXJpZXMuDQorDQog MjAxMi0xMi0wMyAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPg0KIA0K IAkqIGR3YXJmMnJlYWQuYyAoc3RydWN0IGR3YXJmMl9wZXJfb2JqZmlsZSk6 IENsYXJpZnkgY29tbWVudC4NCkluZGV4OiBhbWQ2NC10ZGVwLmMNCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2Ri L2FtZDY0LXRkZXAuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTE1DQpk aWZmIC11IC1wIC1yMS4xMTUgYW1kNjQtdGRlcC5jDQotLS0gYW1kNjQtdGRl cC5jCTI2IE9jdCAyMDEyIDE5OjM0OjA5IC0wMDAwCTEuMTE1DQorKysgYW1k NjQtdGRlcC5jCTQgRGVjIDIwMTIgMDU6MDY6MzAgLTAwMDANCkBAIC0yMjUy LDYgKzIyNTIsMjIgQEAgYW1kNjRfc2tpcF9wcm9sb2d1ZSAoc3RydWN0IGdk YmFyY2ggKmdkYg0KIHsNCiAgIHN0cnVjdCBhbWQ2NF9mcmFtZV9jYWNoZSBj YWNoZTsNCiAgIENPUkVfQUREUiBwYzsNCisgIENPUkVfQUREUiBmdW5jX2Fk ZHI7DQorDQorICBpZiAoZmluZF9wY19wYXJ0aWFsX2Z1bmN0aW9uIChzdGFy dF9wYywgTlVMTCwgJmZ1bmNfYWRkciwgTlVMTCkpDQorICAgIHsNCisgICAg ICBDT1JFX0FERFIgcG9zdF9wcm9sb2d1ZV9wYw0KKwk9IHNraXBfcHJvbG9n dWVfdXNpbmdfc2FsIChnZGJhcmNoLCBmdW5jX2FkZHIpOw0KKyAgICAgIHN0 cnVjdCBzeW10YWIgKnMgPSBmaW5kX3BjX3N5bXRhYiAoZnVuY19hZGRyKTsN CisNCisgICAgICAvKiBDbGFuZyBhbHdheXMgZW1pdHMgYSBsaW5lIG5vdGUg YmVmb3JlIHRoZSBwcm9sb2d1ZSBhbmQgYW5vdGhlcg0KKwkgb25lIGFmdGVy LiAgV2UgdHJ1c3QgY2xhbmcgdG8gZW1pdCB1c2FibGUgbGluZSBub3Rlcy4g ICovDQorICAgICAgaWYgKHBvc3RfcHJvbG9ndWVfcGMNCisJICAmJiAocyAh PSBOVUxMDQorCSAgICAgICYmIHMtPnByb2R1Y2VyICE9IE5VTEwNCisJICAg ICAgJiYgc3RybmNtcCAocy0+cHJvZHVjZXIsICJjbGFuZyAiLCBzaXplb2Yg KCJjbGFuZyAiKSAtIDEpID09IDApKQ0KKyAgICAgICAgcmV0dXJuIG1heCAo c3RhcnRfcGMsIHBvc3RfcHJvbG9ndWVfcGMpOw0KKyAgICB9DQogDQogICBh bWQ2NF9pbml0X2ZyYW1lX2NhY2hlICgmY2FjaGUpOw0KICAgcGMgPSBhbWQ2 NF9hbmFseXplX3Byb2xvZ3VlIChnZGJhcmNoLCBzdGFydF9wYywgMHhmZmZm ZmZmZmZmZmZmZmZmTEwsDQpJbmRleDogaTM4Ni10ZGVwLmMNCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2kz ODYtdGRlcC5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4zNjQNCmRpZmYg LXUgLXAgLXIxLjM2NCBpMzg2LXRkZXAuYw0KLS0tIGkzODYtdGRlcC5jCTIx IE5vdiAyMDEyIDE0OjA5OjEwIC0wMDAwCTEuMzY0DQorKysgaTM4Ni10ZGVw LmMJNCBEZWMgMjAxMiAwNTowNjozMCAtMDAwMA0KQEAgLTE1ODIsNyArMTU4 MiwyMyBAQCBpMzg2X3NraXBfcHJvbG9ndWUgKHN0cnVjdCBnZGJhcmNoICpn ZGJhDQogICBDT1JFX0FERFIgcGM7DQogICBnZGJfYnl0ZSBvcDsNCiAgIGlu dCBpOw0KKyAgQ09SRV9BRERSIGZ1bmNfYWRkcjsNCiANCisgIGlmIChmaW5k X3BjX3BhcnRpYWxfZnVuY3Rpb24gKHN0YXJ0X3BjLCBOVUxMLCAmZnVuY19h ZGRyLCBOVUxMKSkNCisgICAgew0KKyAgICAgIENPUkVfQUREUiBwb3N0X3By b2xvZ3VlX3BjDQorCT0gc2tpcF9wcm9sb2d1ZV91c2luZ19zYWwgKGdkYmFy Y2gsIGZ1bmNfYWRkcik7DQorICAgICAgc3RydWN0IHN5bXRhYiAqcyA9IGZp bmRfcGNfc3ltdGFiIChmdW5jX2FkZHIpOw0KKw0KKyAgICAgIC8qIENsYW5n IGFsd2F5cyBlbWl0cyBhIGxpbmUgbm90ZSBiZWZvcmUgdGhlIHByb2xvZ3Vl IGFuZCBhbm90aGVyDQorCSBvbmUgYWZ0ZXIuICBXZSB0cnVzdCBjbGFuZyB0 byBlbWl0IHVzYWJsZSBsaW5lIG5vdGVzLiAgKi8NCisgICAgICBpZiAocG9z dF9wcm9sb2d1ZV9wYw0KKwkgICYmIChzICE9IE5VTEwNCisJICAgICAgJiYg cy0+cHJvZHVjZXIgIT0gTlVMTA0KKwkgICAgICAmJiBzdHJuY21wIChzLT5w cm9kdWNlciwgImNsYW5nICIsIHNpemVvZiAoImNsYW5nICIpIC0gMSkgPT0g MCkpDQorICAgICAgICByZXR1cm4gbWF4IChzdGFydF9wYywgcG9zdF9wcm9s b2d1ZV9wYyk7DQorICAgIH0NCisgDQogICBjYWNoZS5sb2NhbHMgPSAtMTsN CiAgIHBjID0gaTM4Nl9hbmFseXplX3Byb2xvZ3VlIChnZGJhcmNoLCBzdGFy dF9wYywgMHhmZmZmZmZmZiwgJmNhY2hlKTsNCiAgIGlmIChjYWNoZS5sb2Nh bHMgPCAwKQ0KDQpUaGFua3MNCkthcnRoaWsgDQoNCg0KLS0tLS0tLSBPcmln aW5hbCBNZXNzYWdlIC0tLS0tLS0NClNlbmRlciA6IE1hcmsgS2V0dGVuaXM8 bWFyay5rZXR0ZW5pc0B4czRhbGwubmw+DQpEYXRlIDogTm92IDI3LCAyMDEy IDIwOjE0IChHTVQrMDk6MDApDQpUaXRsZSA6IFJlOiBbUEFUQ0hdIEZpeCBm b3IgaW5jb3JlY3QgYnJlYWtwb2ludCBzZXQgaW4gY2FzZSBvZiBjbGFuZyBj b21waWxlZCBiaW5hcnkNCg0KPiBEYXRlOiBXZWQsIDIxIE5vdiAyMDEyIDE1 OjM5OjIyICswMDAwIChHTVQpDQo+IEZyb206IEtBUlRISUtWRU5LQVRFU0gg QkhBVCANCj4gDQo+IFRoYW5rcyBQZWRyby9NYXJrLiBBcHBvbG9naWVzIGZv ciB0aGUgYnVpbGQgYnJlYWsuIEknbSBhIGJpdCBuZXcgdG8gR0RCIGNvbW11 bml0eSB3aWxsIHRha2UgY2FyZSBvZiBpdCBmcm9tIG5leHQgdGltZS4NCj4g SSBoYXZlIGZpeGVkIHRoZSB3YXJuaW5nIHJlc3VsdGluZyBpbiBlcnJvciBh bmQgbW9kaWZpZWQgdGhlIGluZGVudGF0aW9uIC0NCj4gTGV0IG1lIGFsc28g dHJ5IHRvIGV4cGxhaW4gdGhlIGZpeCBhIGJpdCBtb3JlLiANCj4gDQo+IElu ZGV4OiBDaGFuZ2VMb2cNCj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KPiBS Q1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9DaGFuZ2VMb2csdg0KPiByZXRy aWV2aW5nIHJldmlzaW9uIDEuMTQ4NDkNCj4gZGlmZiAtdSAtcCAtcjEuMTQ4 NDkgQ2hhbmdlTG9nDQo+IC0tLSBDaGFuZ2VMb2cgMjEgTm92IDIwMTIgMTQ6 MDk6MDMgLTAwMDAgMS4xNDg0OQ0KPiArKysgQ2hhbmdlTG9nIDIxIE5vdiAy MDEyIDE1OjExOjQ3IC0wMDAwDQo+IEBAIC0xLDMgKzEsOSBAQA0KPiArMjAx Mi0xMS0yMCAgS2FydGhpayBCaGF0ICANCj4gKw0KPiArICogaTM4Ni10ZGVw LmMgKGkzODZfc2tpcF9wcm9sb2d1ZSk6IFNlZSBpZiB3ZQ0KPiArIGNhbiBk ZXRlcm1pbmUgdGhlIGVuZCBvZiB0aGUgcHJvbG9ndWUgdmlhIHRoZSBzeW1i b2wgdGFibGUuDQo+ICsgSWYgc28gdXNlIHRoZSBzYW1lIGluc3RlYWQgb2Yg Z29pbmcgdGhyb3VnaCBwcm9sb2d1ZSBpbnN0cnVjdGlvbnMuDQo+ICsNCj4g IDIwMTItMTEtMjEgIFlhbyBRaSAgDQo+ICANCj4gICBQUiB0ZGVwLzc0MzgN Cj4gSW5kZXg6IGkzODYtdGRlcC5jDQo+ID09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0NCj4gUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvaTM4Ni10ZGVwLmMs dg0KPiByZXRyaWV2aW5nIHJldmlzaW9uIDEuMzY0DQo+IGRpZmYgLXUgLXAg LXIxLjM2NCBpMzg2LXRkZXAuYw0KPiAtLS0gaTM4Ni10ZGVwLmMgMjEgTm92 IDIwMTIgMTQ6MDk6MTAgLTAwMDAgMS4zNjQNCj4gKysrIGkzODYtdGRlcC5j IDIxIE5vdiAyMDEyIDE1OjExOjQ4IC0wMDAwDQo+IEBAIC0xNTgyLDYgKzE1 ODIsMjcgQEAgaTM4Nl9za2lwX3Byb2xvZ3VlIChzdHJ1Y3QgZ2RiYXJjaCAq Z2RiYQ0KPiAgICBDT1JFX0FERFIgcGM7DQo+ICAgIGdkYl9ieXRlIG9wOw0K PiAgICBpbnQgaTsNCj4gKyAgQ09SRV9BRERSIGZ1bmNfYWRkcjsNCj4gKw0K PiArICBpZiAoZmluZF9wY19wYXJ0aWFsX2Z1bmN0aW9uIChzdGFydF9wYywg TlVMTCwgJmZ1bmNfYWRkciwgTlVMTCkpDQo+ICsgICAgew0KPiArICAgICAg Q09SRV9BRERSIHBvc3RfcHJvbG9ndWVfcGMNCj4gKyA9IHNraXBfcHJvbG9n dWVfdXNpbmdfc2FsIChnZGJhcmNoLCBmdW5jX2FkZHIpOw0KPiArICAgICAg c3RydWN0IHN5bXRhYiAqcyA9IGZpbmRfcGNfc3ltdGFiIChmdW5jX2FkZHIp Ow0KPiArDQo+ICsgICAgICAvKiBHQ0MgYW5kIGNsYW5nIGFsd2F5cyBlbWl0 cyBhIGxpbmUgbm90ZSBiZWZvcmUgdGhlIHByb2xvZ3VlIGFuZCBhbm90aGVy DQo+ICsgb25lIGFmdGVyLCBldmVuIGlmIHRoZSB0d28gYXJlIGF0IHRoZSBz YW1lIGFkZHJlc3Mgb3Igb24gdGhlDQo+ICsgc2FtZSBsaW5lLiAgVGFrZSBh ZHZhbnRhZ2Ugb2YgdGhpcyBzbyB0aGF0IHdlIGRvIG5vdCBuZWVkIHRvDQo+ ICsga25vdyBldmVyeSBpbnN0cnVjdGlvbiB0aGF0IG1pZ2h0IGFwcGVhciBp biB0aGUgcHJvbG9ndWUuICBXZQ0KPiArIHdpbGwgaGF2ZSBwcm9kdWNlciBp bmZvcm1hdGlvbiBmb3IgbW9zdCBiaW5hcmllczsgaWYgaXQgaXMNCj4gKyBt aXNzaW5nIChlLmcuIGZvciAtZ3N0YWJzKSwgYXNzdW1pbmcgdGhlIEdOVSB0 b29scy4gICovDQo+ICsgICAgICBpZiAocG9zdF9wcm9sb2d1ZV9wYw0KPiAr ICAgJiYgKHMgPT0gTlVMTA0KPiArICAgICAgIHx8IHMtPnByb2R1Y2VyID09 IE5VTEwNCj4gKyAgICAgICB8fCBzdHJuY21wIChzLT5wcm9kdWNlciwgIkdO VSAiLCBzaXplb2YgKCJHTlUgIikgLSAxKSA9PSAwIA0KPiArICAgICAgIHx8 IHN0cm5jbXAgKHMtPnByb2R1Y2VyLCAiY2xhbmcgIiwgc2l6ZW9mICgiY2xh bmcgIikgLSAxKSA9PSAwKSkNCj4gKyByZXR1cm4gbWF4IChzdGFydF9wYywg cG9zdF9wcm9sb2d1ZV9wYyk7DQo+ICsgICAgfQ0KPiAgDQo+ICAgIGNhY2hl LmxvY2FscyA9IC0xOw0KPiAgICBwYyA9IGkzODZfYW5hbHl6ZV9wcm9sb2d1 ZSAoZ2RiYXJjaCwgc3RhcnRfcGMsIDB4ZmZmZmZmZmYsICZjYWNoZSk7DQo+ IA0KPiANCj4gSSB3YW50ZWQgdG8gYWRkIHRoaXMgcGF0Y2ggaW4gR0RCIHRv IGZpeCBhIHByb2JsZW0gd2hpY2ggd2UgYXJlDQo+IGN1cnJlbnRseSBmYWNp bmcgd2hlbiB3ZSB1c2UgZ2RiIHdpdGggYmluYXJ5IGNvbXBpbGVkIHdpdGgg Y2xhbmcuDQo+IFRoZSBwcm9ibGVtIGZhY2VkIGlzIGNsYW5nIGdlbmVyYXRl cyBmdW5jdGlvbiBwcm9sb2d1ZSB3aGljaCBpcyBhDQo+IGJpdCBkaWZmZXJl bnQgZnJvbSB0aGF0IG9mIEdDQyBhcyBhIHJlc3VsdCB3aGVuIHdlIHRyeSB0 byBza2lwDQo+IHByb2xvZ3VlIGluc3RydWN0aW9uIGJ5IGluc3RydWN0aW9u IGl0IHJlc3VsdHMgaW4gaW5jb3JyZWN0DQo+IHByb2xvZ3VlX2VuZC4NCg0K SXQgc2hvdWxkIG9ubHkgZXZlciByZXN1bHQgaW4gYSBwcm9sb2d1ZV9lbmQg dGhhdCdzIHBvaW50aW5nIHRvIGFuDQppbnN0cnVjdGlvbiBiZWZvcmUgdGhl ICJyZWFsIiBlbmQgb2YgdGhlIHByb2xvZ3VlLiAgVGhhdCBzaG91bGRuJ3Qg YmUNCmEgYmlnIGlzc3VlIGlmIHlvdXIgY29tcGlsZXIgZW1pdHMgcHJvcGVy IGRlYnVnIGluZm9ybWF0aW9uIChpbg0KcGFydGljdWxhciB1bndpbmQgaW5m b3JtYXRpb24gYWRuIGxvY2F0aW9uIGluZm9ybWF0aW9uKSBmb3IgdGhlDQpw cm9sb2d1ZS4gIFdpdGggdG9kYXkncyBvcHRpbWl6aW5nIGNvbXBpbGVycyB0 aGUgY29uY2VwdCBvZiBmdW5jdGlvbg0KcHJvbG9ndWUgaXMgZnV6enkgYW55 d2F5Lg0KDQo+IFRoZXJlIGlzIG9uZSBtb3JlIG1ldGhvZCB0byBza2lwIHBy b2xvZ3VlIHdoaWNoIGlzIHVzZWQgaW4gb3RoZXINCj4gYXJjaGl0ZWN0dXJl cyBzdWNoIGFzIEFSTShhcm0tdGRlcC5jKSwgTUlQUyhtaXBzLXRkZXAuYykg ZXRjLiBJbg0KPiB0aGlzIG1ldGhvZCB3ZSB0cnkgdG8gZGV0ZXJtaW5lIHBy b2xvZ3VlIGVuZCB2aWEgc3ltYm9sIHRhYmxlLiAgSWYNCj4gd2UgYXJlIHVu YWJsZSB0byBkbyB0aGlzIHdlIHRoZW4gd2UgZXhhbWluZSBpbnN0cnVjdGlv biB0byBkZXRlcm1pbmUNCj4gcHJvbG9ndWUgZW5kLg0KDQpUaGUgcHJvYmxl bSB3aXRoIHRoYXQgYXBwcm9hY2ggaXMgdGhhdCBjb21waWxlcnMgY2FuIG5v dCBhbHdheXMgYmUNCnRydXN0ZWQgdG8gZW1pdCB0aGUgcmlnaHQgaW5mb3Jt YXRpb24gZm9yIHRoaXMgdG8gd29yay4gIEluIHRoZSBwYXN0DQpHQ0MgaGFz IGJlZW4gcGFydGljdWxhcmx5IGZsYWt5IGluIHRoaXMgcmVzcGVjdCwgd2l0 aCB0aGUgdW5mb3J0dW5hdGUNCm91dGNvbWUgdGhhdCB0aGVyZSB3ZXJlIGJy YW5jaCBpbnN0cnVjdGlvbnMgYmVmb3JlIHRoZSB0aGUgcHJvbG9ndWUNCmVu ZCBhcyBkZXRlcm1pbmVkIHZpYSB0aGUgc3ltYm9sIHRhYmxlLiAgVGhhdCBt YWtlcyBkZWJ1Z2dpbmcgcmVhbGx5LA0KcmVhbGx5IHBhaW5mdWwuDQoNCklm IHlvdSBjYW4gdm91Y2ggZm9yIGNsYW5nIGFsd2F5cyBnZXR0aW5nIHRoaXMg cmlnaHQsIEkgaGF2ZSBubw0Kb2JqZWN0aW9uIGRvaW5nIHRoaXMgd2hlbiBj bGFuZyBpcyB0aGUgcHJvZHVjZXIuICBQZXJoYXBzIHRoZXNlIGRheXMNCkdD QyBjYW4gYmUgdHJ1c3RlZCBhcyB3ZWxsLiAgQnV0IHdlJ2QgbmVlZCBhIHZl cnNpb24gY2hlY2sgdG8gbWFrZQ0Kc3VyZSB3ZSBkb24ndCB1c2UgdGhlIHN5 bWJvbCB0YWJsZSBhcHByb2FjaCBvbiBrbm93biB0byBiZSBicm9rZW4NCnZl cnNpb25zIG9mIEdDQy4gIFByb2JhYmx5IHRoZSBiZXN0IHRoaW5nIHdvdWxk IGJlIHRvIGVzdGFibGlzaCBhDQprbm93bi10by1iZS1nb29kIHZlcnNpb24g b2YgR0NDIGFuZCBvbmx5IHVzZSB0aGUgc3ltYm9sIHRhYmxlIGFwcHJvYWNo DQpmb3IgR0NDIHN0YXJ0aW5nIHdpdGggdGhhdCB2ZXJzaW9uIG51bWJlci4N Cg0KSWYgeW91ciBpbW1lZGlhdGUgZ29hbCBpcyB0byBmaXggdGhpbmdzIGZv ciBjbGFuZywgSSByZWNvbW1lbmQgeW91DQpyZXN1Ym1pdCB5b3VyIGNoYW5n ZSBhZGRyZXNzaW5nIG9ubHkgY2xhbmcgYW5kIHdvcnJ5IGFib3V0IEdDQyBs YXRlcg0KKG9yIGxldCBzb21lYm9keSBlbHNlIHdvcnJ5IGFib3V0IGl0KS4g IEJlIHN1cmUgdG8gdXBkYXRlIHRoZSBjb21tZW50Lg0KSSdkIHNpbXBsZSBy ZXBsYWNlIGl0IHdpdGggc29tZXRoaW5nIGxpa2UgIldlIHRydXN0IGNsYW5n IHRvIGVtaXQNCnVzYWJsZSBsaW5lIG5vdGVzIi4NCg0KWW91IHByb2JhYmx5 IHdhbnQgdG8gYWRkIHNpbWlsYXIgY29kZSB0byB0aGUgcHJvbG9ndWUgc2tp cHBpbmcgY29kZSBpbg0KYW1kNjQtdGRlcC5jLg0KDQpDaGVlcnMsDQoNCk1h cms= >From gdb-patches-return-96582-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Dec 04 07:10:23 2012 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 25844 invoked by alias); 4 Dec 2012 07:10:22 -0000 Received: (qmail 25834 invoked by uid 22791); 4 Dec 2012 07:10:21 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Dec 2012 07:10:13 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id qB479sdA024620; Tue, 4 Dec 2012 08:09:54 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id qB479ppK023958; Tue, 4 Dec 2012 08:09:51 +0100 (CET) Date: Tue, 04 Dec 2012 07:10:00 -0000 Message-Id: <201212040709.qB479ppK023958@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: kv.bhat@samsung.com CC: mark.kettenis@xs4all.nl, kv.bhat@samsung.com, palves@redhat.com, gdb-patches@sourceware.org, tromey@redhat.com In-reply-to: <20101179.243591354601368727.JavaMail.weblogic@epml08> (message from KARTHIKVENKATESH BHAT on Tue, 04 Dec 2012 06:09:29 +0000 (GMT)) Subject: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary References: <20101179.243591354601368727.JavaMail.weblogic@epml08> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org X-SW-Source: 2012-12/txt/msg00055.txt.bz2 Content-length: 3279 > Date: Tue, 04 Dec 2012 06:09:29 +0000 (GMT) > From: KARTHIKVENKATESH BHAT > > Hi Mark/Tom/Palves, > Thanks for taking your time out for review. > I have implemented the review comments. Please let me know if i can commit the same. > > cvs diff: Diffing . > Index: ChangeLog > =================================================================== > RCS file: /cvs/src/src/gdb/ChangeLog,v > retrieving revision 1.14880 > diff -u -p -r1.14880 ChangeLog > --- ChangeLog 3 Dec 2012 22:31:02 -0000 1.14880 > +++ ChangeLog 4 Dec 2012 05:06:29 -0000 > @@ -1,3 +1,10 @@ > +2012-12-04 Karthik Bhat > + > + * i386-tdep.c (i386_skip_prologue): Using symbol table > + to find the end of prologue for clang compiled binaries. > + * amd64-tdep.c (amd64_skip_prologue):Using symbol table > + to find the end of prologue for clang compiled binaries. Missing space between : and Using in your ChangeLog entry. Otherwise this looks ok to me. > Index: amd64-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/amd64-tdep.c,v > retrieving revision 1.115 > diff -u -p -r1.115 amd64-tdep.c > --- amd64-tdep.c 26 Oct 2012 19:34:09 -0000 1.115 > +++ amd64-tdep.c 4 Dec 2012 05:06:30 -0000 > @@ -2252,6 +2252,22 @@ amd64_skip_prologue (struct gdbarch *gdb > { > struct amd64_frame_cache cache; > CORE_ADDR pc; > + CORE_ADDR func_addr; > + > + if (find_pc_partial_function (start_pc, NULL, &func_addr, NULL)) > + { > + CORE_ADDR post_prologue_pc > + = skip_prologue_using_sal (gdbarch, func_addr); > + struct symtab *s = find_pc_symtab (func_addr); > + > + /* Clang always emits a line note before the prologue and another > + one after. We trust clang to emit usable line notes. */ > + if (post_prologue_pc > + && (s != NULL > + && s->producer != NULL > + && strncmp (s->producer, "clang ", sizeof ("clang ") - 1) == 0)) > + return max (start_pc, post_prologue_pc); > + } > > amd64_init_frame_cache (&cache); > pc = amd64_analyze_prologue (gdbarch, start_pc, 0xffffffffffffffffLL, > Index: i386-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/i386-tdep.c,v > retrieving revision 1.364 > diff -u -p -r1.364 i386-tdep.c > --- i386-tdep.c 21 Nov 2012 14:09:10 -0000 1.364 > +++ i386-tdep.c 4 Dec 2012 05:06:30 -0000 > @@ -1582,7 +1582,23 @@ i386_skip_prologue (struct gdbarch *gdba > CORE_ADDR pc; > gdb_byte op; > int i; > + CORE_ADDR func_addr; > > + if (find_pc_partial_function (start_pc, NULL, &func_addr, NULL)) > + { > + CORE_ADDR post_prologue_pc > + = skip_prologue_using_sal (gdbarch, func_addr); > + struct symtab *s = find_pc_symtab (func_addr); > + > + /* Clang always emits a line note before the prologue and another > + one after. We trust clang to emit usable line notes. */ > + if (post_prologue_pc > + && (s != NULL > + && s->producer != NULL > + && strncmp (s->producer, "clang ", sizeof ("clang ") - 1) == 0)) > + return max (start_pc, post_prologue_pc); > + } > + > cache.locals = -1; > pc = i386_analyze_prologue (gdbarch, start_pc, 0xffffffff, &cache); > if (cache.locals < 0) >