From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20092 invoked by alias); 24 Nov 2010 17:20:16 -0000 Received: (qmail 20082 invoked by uid 22791); 24 Nov 2010 17:20:16 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Nov 2010 17:20:10 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7256B2BAB32; Wed, 24 Nov 2010 12:20:08 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id O2L0ZLHpWheC; Wed, 24 Nov 2010 12:20:08 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 22CDC2BAB2B; Wed, 24 Nov 2010 12:20:08 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 447571457E1; Wed, 24 Nov 2010 09:20:02 -0800 (PST) Date: Wed, 24 Nov 2010 17:20:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS) Message-ID: <20101124172002.GZ2634@adacore.com> References: <1290474834-1945-1-git-send-email-brobecker@adacore.com> <201011231242.44422.pedro@codesourcery.com> <201011231628.33851.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201011231628.33851.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00392.txt.bz2 > 2010-11-23 Pedro Alves > > gdb/ > * breakpoint.h: No longer include python.h or python-internal.h. > (struct breakpoint_object): Forward declare. > * defs.h (PyObject) [!HAVE_PYTHON]: Don't define. > * varobj.c (PyObject) [!HAVE_PYTHON]: Define. > * python/py-breakpoint.c (build_bp_list): Cast py_bp_object to > PyObject pointer. > (gdbpy_breakpoint_created): Remove casts around py_bp_object > accesses. Thanks, Pedro! I confirm that this fixes the problem. Can we check it in? (review needed?) -- Joel