From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76551-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24088 invoked by alias); 22 Nov 2010 19:19:42 -0000
Received: (qmail 24076 invoked by uid 22791); 22 Nov 2010 19:19:41 -0000
X-SWARE-Spam-Status: No, hits=-5.5 required=5.0	tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Nov 2010 19:19:37 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAMJJD4K019813	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 22 Nov 2010 14:19:13 -0500
Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oAMJJ7NK015007	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Mon, 22 Nov 2010 14:19:12 -0500
Received: from host0.dyn.jankratochvil.net (localhost.localdomain [127.0.0.1])	by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id oAMJJ7Oq021420;	Mon, 22 Nov 2010 20:19:07 +0100
Received: (from jkratoch@localhost)	by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id oAMJJ5gi021419;	Mon, 22 Nov 2010 20:19:05 +0100
Date: Mon, 22 Nov 2010 19:19:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch 2/2] iFort compat.: case insensitive symbols (PR 11313)
Message-ID: <20101122191905.GA20976@host0.dyn.jankratochvil.net>
References: <m3wroi4br5.fsf@fleche.redhat.com> <20101108183133.GE2933@adacore.com> <20101122035334.GA9229@host0.dyn.jankratochvil.net> <20101122185432.GT2634@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101122185432.GT2634@adacore.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-11/txt/msg00308.txt.bz2

On Mon, 22 Nov 2010 19:54:32 +0100, Joel Brobecker wrote:
> > +	  hash = SYMBOL_HASH_NEXT (hash, *string);
> [...]
> > +#define SYMBOL_HASH_NEXT(hash, c) \
> > +  ((hash) * 67 + tolower ((unsigned char) (c)) - 113)
> 
> The lowercasing of the character impact the hash's overal performance?

If there are any concerns about it (I do not think there should be any while
looking and the disassembly plus glibc's __ctype_tolower_loc) we should also
ask why GDB already uses locale-conforming tolower while gcc uses TOLOWER.

GDB could also use it, it is in libiberty.  That one has "zero" cost.


Thanks,
Jan