From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch 2/2] iFort compat.: case insensitive symbols (PR 11313)
Date: Mon, 22 Nov 2010 18:54:00 -0000 [thread overview]
Message-ID: <20101122185432.GT2634@adacore.com> (raw)
In-Reply-To: <20101122035334.GA9229@host0.dyn.jankratochvil.net>
> Here is a draft, not yet for review.
So - what do you think? I'm a little torn, because of the following
change which I did not anticipate:
> default:
> - hash = hash * 67 + *string - 113;
> + hash = SYMBOL_HASH_NEXT (hash, *string);
[...]
> +#define SYMBOL_HASH_NEXT(hash, c) \
> + ((hash) * 67 + tolower ((unsigned char) (c)) - 113)
The lowercasing of the character impact the hash's overal performance?
Your first patch only affects the languages for which the language
is marked as case-insensitive, whereas the second one seems to affect
all languages. If the impact is sufficiently noticeable, then that
would be an argument in favor of your first patch...
(just thinking aloud)
--
Joel
next prev parent reply other threads:[~2010-11-22 18:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-07 3:50 Jan Kratochvil
2010-11-08 16:36 ` Joel Brobecker
2010-11-08 17:02 ` Jan Kratochvil
2010-11-08 18:31 ` Joel Brobecker
2010-11-22 3:54 ` Jan Kratochvil
2010-11-22 18:54 ` Joel Brobecker [this message]
2010-11-22 19:19 ` Jan Kratochvil
2010-11-22 19:30 ` Joel Brobecker
2010-11-22 19:44 ` Jan Kratochvil
2010-11-22 19:57 ` Joel Brobecker
2010-11-24 18:53 ` Tom Tromey
2010-11-24 19:22 ` Jan Kratochvil
2010-11-24 20:01 ` Tom Tromey
2010-11-24 20:08 ` Joel Brobecker
2010-11-24 21:37 ` Tom Tromey
2010-11-24 21:45 ` Jan Kratochvil
2010-11-24 21:55 ` Tom Tromey
2010-11-24 20:17 ` Jan Kratochvil
2010-11-24 20:31 ` Joel Brobecker
2010-11-24 20:58 ` Jan Kratochvil
2011-04-08 17:59 ` obsolete: " Jan Kratochvil
2010-11-08 17:18 ` Pierre Muller
-- strict thread matches above, loose matches on Subject: below --
2010-11-07 3:50 [patch 1/2] Code cleanup: New init_one_comp_unit Jan Kratochvil
2010-11-12 18:36 ` Tom Tromey
2010-11-12 18:43 ` Jan Kratochvil
2010-11-12 18:46 ` Tom Tromey
2010-11-16 4:37 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122185432.GT2634@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox