From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7475 invoked by alias); 22 Nov 2010 17:46:14 -0000 Received: (qmail 7463 invoked by uid 22791); 22 Nov 2010 17:46:13 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Nov 2010 17:46:07 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAMHjmCQ001045 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 22 Nov 2010 12:45:48 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oAMHjh8g014515 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 22 Nov 2010 12:45:47 -0500 Received: from host0.dyn.jankratochvil.net (localhost.localdomain [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id oAMHjgYG018190; Mon, 22 Nov 2010 18:45:42 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id oAMHjeGe018189; Mon, 22 Nov 2010 18:45:40 +0100 Date: Mon, 22 Nov 2010 17:46:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Thiago Jung Bauermann , Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [patch 2/2] Implement support for PowerPC BookE masked and ranged watchpoints Message-ID: <20101122174540.GA18165@host0.dyn.jankratochvil.net> References: <1288403952.2598.58.camel@hactar> <83wrp05f2f.fsf@gnu.org> <1288648026.3377.7.camel@hactar> <83d3qo5qkj.fsf@gnu.org> <1288905125.14606.4.camel@hactar> <20101116040116.GA19243@host0.dyn.jankratochvil.net> <1290196508.5540.101.camel@hactar> <20101119234530.GL2634@adacore.com> <1290445473.3164.1.camel@hactar> <20101122173830.GR2634@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101122173830.GR2634@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00305.txt.bz2 On Mon, 22 Nov 2010 18:38:30 +0100, Joel Brobecker wrote: > > I will divide the patch in 3, one for ranged watchpoints, another for > > masked watchpoints and one for the watch-range command. Was this > > division you were thinking of? > > Yes - but I'd recommend doing it only if that helps either Jan or > yourself in the review process. Now that the whole patch got reviewed, > then perhaps it's no longer useful to do so? There are already many GDB commands, I do not want to block the patch due to some additional IMO redundant ones, if other maintainers are fine with it. Regards, Jan