From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11923 invoked by alias); 22 Nov 2010 17:38:41 -0000 Received: (qmail 11830 invoked by uid 22791); 22 Nov 2010 17:38:40 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Nov 2010 17:38:36 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 57D9A2BAC19; Mon, 22 Nov 2010 12:38:34 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id py2ciHQEm7C6; Mon, 22 Nov 2010 12:38:34 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 07B6D2BAB1B; Mon, 22 Nov 2010 12:38:32 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 287101457E1; Mon, 22 Nov 2010 09:38:30 -0800 (PST) Date: Mon, 22 Nov 2010 17:38:00 -0000 From: Joel Brobecker To: Thiago Jung Bauermann Cc: Jan Kratochvil , Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [patch 2/2] Implement support for PowerPC BookE masked and ranged watchpoints Message-ID: <20101122173830.GR2634@adacore.com> References: <838w1p8egs.fsf@gnu.org> <1288403952.2598.58.camel@hactar> <83wrp05f2f.fsf@gnu.org> <1288648026.3377.7.camel@hactar> <83d3qo5qkj.fsf@gnu.org> <1288905125.14606.4.camel@hactar> <20101116040116.GA19243@host0.dyn.jankratochvil.net> <1290196508.5540.101.camel@hactar> <20101119234530.GL2634@adacore.com> <1290445473.3164.1.camel@hactar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1290445473.3164.1.camel@hactar> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00304.txt.bz2 > I will divide the patch in 3, one for ranged watchpoints, another for > masked watchpoints and one for the watch-range command. Was this > division you were thinking of? Yes - but I'd recommend doing it only if that helps either Jan or yourself in the review process. Now that the whole patch got reviewed, then perhaps it's no longer useful to do so? -- Joel