From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24071 invoked by alias); 20 Nov 2010 05:00:03 -0000 Received: (qmail 24006 invoked by uid 22791); 20 Nov 2010 05:00:01 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 20 Nov 2010 04:59:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AE8212BAC99; Fri, 19 Nov 2010 23:59:55 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mSyKrSI1LrMo; Fri, 19 Nov 2010 23:59:55 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6E5BF2BAC96; Fri, 19 Nov 2010 23:59:55 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 503E21457E0; Fri, 19 Nov 2010 20:59:51 -0800 (PST) Date: Sat, 20 Nov 2010 05:00:00 -0000 From: Joel Brobecker To: Thiago Jung Bauermann Cc: Jan Kratochvil , Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [patch 2/2] Implement support for PowerPC BookE masked and ranged watchpoints Message-ID: <20101120045951.GN2634@adacore.com> References: <1282074110.2606.703.camel@hactar> <1287807761.10521.423.camel@hactar> <838w1p8egs.fsf@gnu.org> <1288403952.2598.58.camel@hactar> <83wrp05f2f.fsf@gnu.org> <1288648026.3377.7.camel@hactar> <83d3qo5qkj.fsf@gnu.org> <1288905125.14606.4.camel@hactar> <20101116040116.GA19243@host0.dyn.jankratochvil.net> <1290196508.5540.101.camel@hactar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1290196508.5540.101.camel@hactar> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00286.txt.bz2 > Changed to: > > +The watchpoint will stop execution of the inferior whenever it\n\ > +writes to any address within the [start-address, end-address] range\n\ > +(including start-address and end-address).")); Can you move the "writes" to the line before? This is to prevent breaking line between the subject and the verb, making it easier for the user to read... > Previous patches in this series also used this style and were accepted, > so there's currently code like that in ppc-linux-nat.c in CVS HEAD > (e.g., ppc_linux_{insert,remove}_hw_breakpoint, > ppc_linux_{insert,remove}_watchpoint). Should I keep this patch like > this for consistency, or change this patch and the existing instances? You'll have to excuse us, because not all of us are aware of the entire coding standard used in GDB. It makes me want to revive the idea of a Wiki page, because I need some kind of table/list to remind me of all of them. If it's against the CS, then I'd just fix the instances there, and let anyone changing the code on the other instances worry about that (or you can do that already as an (obvious) separate patch). -- Joel