Re: [patch 2/2] Implement support for PowerPC BookE masked and ranged watchpoints

Eli Zaretskii
2010-11-02T03:53:42Z

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: gdb-patches@sourceware.org
> Date: Mon, 01 Nov 2010 19:47:06 -0200
>
> What about this?
>
> /* The watchpoint will trigger if the address of the memory access is
> within the defined range, as follows: p.addr <= address < p.addr2.
>
> Note that the above sentence just documents how ptrace interprets
> its arguments; the watchpoint is set to watch the range defined by
> the user _inclusively_, as specified by the user interface. */

That's fine, thanks.

> +* GDB now supports ranged watchpoints, which stop the inferior when it
> + accesses any address within a specified memory range. See the
> + documentation on the watch-range command for more information. The
> + watchpoint is hardware-accelerated on some targets (currently only when
> + locally debugging programs on PowerPC BookE processors running a Linux
> + kernel version 2.6.34 or later.)

The last period should be outside the parentheses.

> +* Also on native debugging on Linux running on PowerPC BookE, GDB supports
^^
"for"

> + masked hardware watchpoints, which specifiy a mask in addition to an
> + address to watch. The mask specifies that some bits of an address (the
> + bits which are reset in the mask) should be ignored when matching the
> + address accessed by the inferior against the watchpoint address.

A pointer to the corresponding section in the manual would be good
here.

> +watch
> + The watch command now supports the mask argument which allows creation
> + of masked watchpoints, if the current architecture supports this feature.

Instead of just "watch", I suggest to show here its form with a mask.

OK with those changes.