Re: [patch 2/2] Implement support for PowerPC BookE masked and ranged watchpoints

Thiago Jung Bauermann
2010-11-23T22:05:04Z

On Fri, 2010-11-19 at 20:59 -0800, Joel Brobecker wrote:
> > Changed to:
> >
> > +The watchpoint will stop execution of the inferior whenever it\n\
> > +writes to any address within the [start-address, end-address] range\n\
> > +(including start-address and end-address)."));
>
> Can you move the "writes" to the line before? This is to prevent
> breaking line between the subject and the verb, making it easier
> for the user to read...

Ok. Fixed in the patch I just posted.

> > Previous patches in this series also used this style and were accepted,
> > so there's currently code like that in ppc-linux-nat.c in CVS HEAD
> > (e.g., ppc_linux_{insert,remove}_hw_breakpoint,
> > ppc_linux_{insert,remove}_watchpoint). Should I keep this patch like
> > this for consistency, or change this patch and the existing instances?
>
> You'll have to excuse us, because not all of us are aware of the entire
> coding standard used in GDB. It makes me want to revive the idea of
> a Wiki page, because I need some kind of table/list to remind me of
> all of them. If it's against the CS, then I'd just fix the instances
> there, and let anyone changing the code on the other instances worry
> about that (or you can do that already as an (obvious) separate patch).

No problem. I fixed the whitespace in my patch. I'll commit a separate
obvious patch later then.
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center