From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6205 invoked by alias); 19 Nov 2010 16:37:53 -0000 Received: (qmail 6049 invoked by uid 22791); 19 Nov 2010 16:37:51 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Nov 2010 16:37:46 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAJGbh2B021500 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Nov 2010 11:37:44 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oAJGbc6b019016 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 19 Nov 2010 11:37:42 -0500 Received: from host0.dyn.jankratochvil.net (localhost.localdomain [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id oAJGbaHS025099; Fri, 19 Nov 2010 17:37:36 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id oAJGbYBF025097; Fri, 19 Nov 2010 17:37:34 +0100 Date: Fri, 19 Nov 2010 16:37:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: Patch: check for over- and under-flow in decode_locdesc Message-ID: <20101119163734.GA24966@host0.dyn.jankratochvil.net> References: <20101119062458.GA3514@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00261.txt.bz2 On Fri, 19 Nov 2010 17:32:38 +0100, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > Jan> I will check in the testcase later and if OK. > > I am curious to know how you made this. > Did you just write it by hand? Yes, copy+modify dw2-bad-parameter-type.{exp,S}. Sometimes thinking after writing so many gdb.dwarf2/ testcases it could be more time effective to write some script generator for it instead. OTOH the gdb.dwarf2/ testcases are for various special cases of DWARF and even about invalid DWARF. So which generated parts can be automated? Maybe not many. Regards, Jan