From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10393 invoked by alias); 18 Nov 2010 17:44:39 -0000 Received: (qmail 10384 invoked by uid 22791); 18 Nov 2010 17:44:38 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Nov 2010 17:44:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EFFC22BAAE8; Thu, 18 Nov 2010 12:44:29 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id YS4slmV1OQZy; Thu, 18 Nov 2010 12:44:29 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B36E02BAAE5; Thu, 18 Nov 2010 12:44:29 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B2168145B6C; Thu, 18 Nov 2010 09:44:27 -0800 (PST) Date: Thu, 18 Nov 2010 17:44:00 -0000 From: Joel Brobecker To: Ken Werner Cc: gdb-patches@sourceware.org Subject: Re: [patch, libiberty, gdb] IEEE 754 half floating-point format Message-ID: <20101118174427.GG2634@adacore.com> References: <201007021859.05191.ken@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201007021859.05191.ken@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00242.txt.bz2 > include/ChangeLog: > > 2010-07-02 Ken Werner > > * gfloatformat.h (floatformat_ieee_half_big): Add declaration. ^^^ typo > (floatformat_ieee_half_little): Likewise. > > libiberty/ChangeLog: > > 2010-07-02 Ken Werner > > * floatformat.c (floatformat_ieee_half_big): New variable. > (floatformat_ieee_half_little): Likewise. This part should be submitted to GCC, I think? > 2010-07-02 Ken Werner > > * gdbtypes.h (floatformats_ieee_half): Add declaration. > * gdbtypes.c (floatformats_ieee_half): New variable. > * doublest.c (floatformat_from_length): Set format to > gdbarch_half_format if length matches. > * gdbarch.sh (half_bit): New architecture method. > (half_format): Likewise. > * gdbarch.h: Regenerate. > * gdbarch.c: Likewise. My only comment regarding this part of the patch is that "half_bit" and "half_format" isn't very intuitive. Perhaps that's more obvious to someone who programs in OpenCL if "half" is a type name? For the other arch routines, the routine name makes it clear that it's about floating point types, because it contains a name that is clearly associated to floats (float, double, long double). What about using "half_float_bit" and "half_float_format"? What do others think? -- Joel