From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27086 invoked by alias); 18 Nov 2010 17:13:16 -0000 Received: (qmail 27077 invoked by uid 22791); 18 Nov 2010 17:13:15 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Nov 2010 17:13:11 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9B7BE2BAB68; Thu, 18 Nov 2010 12:13:09 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qF986xHF2cbi; Thu, 18 Nov 2010 12:13:09 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 388E72BAB1F; Thu, 18 Nov 2010 12:13:08 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 43E43145B6C; Thu, 18 Nov 2010 09:13:07 -0800 (PST) Date: Thu, 18 Nov 2010 17:13:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Thiago Jung Bauermann , Pedro Alves , gdb-patches@sourceware.org Subject: Re: [patch] Renaming: {insert,remove} += _location [Re: [patch 1/2] Convert hardware watchpoints to use breakpoint_ops] Message-ID: <20101118171307.GB2634@adacore.com> References: <1282074071.2606.702.camel@hactar> <201010161843.43062.pedro@codesourcery.com> <1287534691.2686.17.camel@hactar> <20101116040625.GB19243@host0.dyn.jankratochvil.net> <20101116080721.GC4434@adacore.com> <20101116185101.GA32061@host0.dyn.jankratochvil.net> <20101117034707.GB12159@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101117034707.GB12159@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00236.txt.bz2 > gdb/ > 2010-11-17 Jan Kratochvil > > Code cleanup - renaming. > * breakpoint.c (insert_bp_location): Use the new name > breakpoint_ops->insert_location. > (remove_breakpoint_1): Use the new name > breakpoint_ops->remove_location. > * breakpoint.h (struct breakpoint_ops): Rename insert to > insert_location and remove to remove_location. I didn't think it would change much, but I changed my mind - I like this change! Thanks for pursuing this. -- Joel