From: Joel Brobecker <brobecker@adacore.com>
To: JuYoung Kim <j0.kim@samsung.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Re: Re: [patch]change dwarf2_start_subfile() to adapt inappropriate dir name
Date: Wed, 17 Nov 2010 19:22:00 -0000 [thread overview]
Message-ID: <20101117192156.GD4434@adacore.com> (raw)
In-Reply-To: <21410336.44431289952805399.JavaMail.weblogic@epml19>
> I have trouble with the cvs server, because my company's firewall
> doesn't allow me to connect it. Instead of me, you or someone can
> commit this patch, I hope.
Checking in the patch for you should be no problem. However,
you still need to submit the patch in a way that helps us review
and then apply it, which means a "diff" file. Instead of using
CVS, I recommend a pure diff between the untouched file and
the new version.
You'll also need to follow the instructions given in the CONTRIBUTE
file as I pointed out (provide a ChangeLog entry, etc), as well as
inform us how you tested the change. Normally, we require that you
run the testsuite before and after, and verify that it does not
introduce any regression.
> My mailer doesn't support the email threading.
> Maybe I'll change my email address.
If you are planning on sending regular contributions, I would recommend
that. Otherwise, I don't think it's worth the effort.
--
Joel
prev parent reply other threads:[~2010-11-17 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 0:13 JuYoung Kim
2010-11-17 19:22 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117192156.GD4434@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=j0.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox