From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20759 invoked by alias); 16 Nov 2010 22:36:33 -0000 Received: (qmail 20714 invoked by uid 22791); 16 Nov 2010 22:36:31 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Nov 2010 22:36:26 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAGMaPF9015876 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 16 Nov 2010 17:36:25 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oAGMaKf0004380 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 16 Nov 2010 17:36:24 -0500 Received: from host0.dyn.jankratochvil.net (localhost.localdomain [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id oAGMaJJL005607; Tue, 16 Nov 2010 23:36:19 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id oAGMaIEZ005606; Tue, 16 Nov 2010 23:36:18 +0100 Date: Tue, 16 Nov 2010 22:36:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patch] Handle absent "/usr/sbin/" in prelink error output. Message-ID: <20101116223618.GB2703@host0.dyn.jankratochvil.net> References: <20101116211114.EAB2A2460AB@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00218.txt.bz2 On Tue, 16 Nov 2010 22:23:35 +0100, Doug Evans wrote: > On Tue, Nov 16, 2010 at 1:11 PM, Doug Evans wrote: > > --- lib/prelink-support.exp     12 Oct 2010 18:12:49 -0000      1.3 > > +++ lib/prelink-support.exp     16 Nov 2010 21:06:58 -0000 > > @@ -221,7 +221,7 @@ proc prelink_no {arg {name {}}} { > >     } > >     # Last line does miss the trailing \n.  There can be multiple such messages > >     # as ARG may list multiple files. > > -    if {$result == 1 && [regexp {^(/usr/sbin/prelink[^\r\n]*: [^ ]* does not have .gnu.prelink_undo section\n?)*$} $output]} { > > +    if {$result == 1 && [regexp {^((/usr/sbin/)?prelink[^\r\n]*: [^ ]* does not have .gnu.prelink_undo section\n?)*$} $output]} { > >        pass $test > >        return 1 > >     } else { > > > > Well, this shouldn't have caused a regression, but break-interp.exp > breaks badly with it. > So there's a deeper bug here. Blech. I do not have any of the problems reproducible on Fedora 14 x86_64 (which is understandable as the testcases were written on this platform). I do not see why your proposed patch should break anything. But speaking specifically about gdb.base/attach-pie-misread.exp I am free to drop it whole. The problem is very difficult to reliably reproduce, various memory alignments must match to make the former problem reproducible. Thanks, Jan