From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2711 invoked by alias); 16 Nov 2010 21:11:26 -0000 Received: (qmail 2701 invoked by uid 22791); 16 Nov 2010 21:11:25 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Nov 2010 21:11:18 +0000 Received: from kpbe20.cbf.corp.google.com (kpbe20.cbf.corp.google.com [172.25.105.84]) by smtp-out.google.com with ESMTP id oAGLBGdK024693 for ; Tue, 16 Nov 2010 13:11:16 -0800 Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.18.118.116]) by kpbe20.cbf.corp.google.com with ESMTP id oAGLBFEt028787 for ; Tue, 16 Nov 2010 13:11:15 -0800 Received: by ruffy.mtv.corp.google.com (Postfix, from userid 67641) id EAB2A2460AB; Tue, 16 Nov 2010 13:11:14 -0800 (PST) To: gdb-patches@sourceware.org Subject: [patch] Handle absent "/usr/sbin/" in prelink error output. Message-Id: <20101116211114.EAB2A2460AB@ruffy.mtv.corp.google.com> Date: Tue, 16 Nov 2010 21:11:00 -0000 From: dje@google.com (Doug Evans) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00213.txt.bz2 Hi. I'm seeing the following output from prelink: prelink: /g3/gnu/sourceware/pretty-printers/build/obj64/gdb/testsuite/gdb.base/attach-pie-misread.d/ld-linux-x86-64.so.2 does not have .gnu.prelink_undo section which causes attach-pie-misread.exp to fail with: FAIL: gdb.base/attach-pie-misread.exp: unprelink ld-linux-x86-64.so.2 pre-unprelink I will check in the following patch in two days if there are no objections. 2010-11-16 Doug Evans * lib/prelink-support.exp (prelink_no): Handle absent "/usr/sbin/" in prelink error output. Index: lib/prelink-support.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/lib/prelink-support.exp,v retrieving revision 1.3 diff -u -p -r1.3 prelink-support.exp --- lib/prelink-support.exp 12 Oct 2010 18:12:49 -0000 1.3 +++ lib/prelink-support.exp 16 Nov 2010 21:06:58 -0000 @@ -221,7 +221,7 @@ proc prelink_no {arg {name {}}} { } # Last line does miss the trailing \n. There can be multiple such messages # as ARG may list multiple files. - if {$result == 1 && [regexp {^(/usr/sbin/prelink[^\r\n]*: [^ ]* does not have .gnu.prelink_undo section\n?)*$} $output]} { + if {$result == 1 && [regexp {^((/usr/sbin/)?prelink[^\r\n]*: [^ ]* does not have .gnu.prelink_undo section\n?)*$} $output]} { pass $test return 1 } else {