From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24477 invoked by alias); 16 Nov 2010 18:51:59 -0000 Received: (qmail 24468 invoked by uid 22791); 16 Nov 2010 18:51:58 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Nov 2010 18:51:42 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAGIpGt3028768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 16 Nov 2010 13:51:16 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oAGIpCIZ014027 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 16 Nov 2010 13:51:15 -0500 Received: from host0.dyn.jankratochvil.net (localhost.localdomain [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id oAGIp9A4032115; Tue, 16 Nov 2010 19:51:09 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id oAGIp1KL032109; Tue, 16 Nov 2010 19:51:01 +0100 Date: Tue, 16 Nov 2010 18:51:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Thiago Jung Bauermann , Pedro Alves , gdb-patches@sourceware.org Subject: Re: [patch 1/2] Convert hardware watchpoints to use breakpoint_ops Message-ID: <20101116185101.GA32061@host0.dyn.jankratochvil.net> References: <1282074071.2606.702.camel@hactar> <201010161843.43062.pedro@codesourcery.com> <1287534691.2686.17.camel@hactar> <20101116040625.GB19243@host0.dyn.jankratochvil.net> <20101116080721.GC4434@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101116080721.GC4434@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00207.txt.bz2 On Tue, 16 Nov 2010 09:07:21 +0100, Joel Brobecker wrote: > How about doing such a rename as a patch on its own? OK, going to send one today. > I don't have any issue with blocking checkin of this patch until patches > implementing your suggestions are approved, if that helps. If one uses some IDE there is probably not a problem with the variable->type association so I do not request a patch block. > That's a good point, though. Perhaps a documentation update can help > make that clearer. OK with a separate patch? It should be made somewhere clear when it is bpt and when it is bp-loc. Thanks, Jan