From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32634 invoked by alias); 12 Nov 2010 16:43:46 -0000 Received: (qmail 32625 invoked by uid 22791); 12 Nov 2010 16:43:45 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Nov 2010 16:43:40 +0000 Received: (qmail 15765 invoked from network); 12 Nov 2010 16:43:38 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 12 Nov 2010 16:43:38 -0000 From: Pedro Alves To: Marc Khouzam Subject: Re: [MI][patch] broken -target-detach Date: Fri, 12 Nov 2010 16:43:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; ) Cc: "'gdb-patches@sourceware.org'" , "'Tom Tromey'" References: <201010160047.03094.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201011121643.34464.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00158.txt.bz2 On Friday 12 November 2010 16:01:20, Marc Khouzam wrote: > > Unfortunately, 7.2 was released accepting the PID form only, > > so we may be better off continue accepting it... > > If we put this fix in the 7.2 branch, could we get rid of the > PID form or is it too late? IMO, it's too late for 7.2. Having 7.2 and 7.2.1 handle this command's argument incompatibly would cause pain for frontends already passing it an argument, and we can avoid causing that pain. So IMO, since it's quite easy to do so, we should continue handling it. We can consider mentioning in the manual that the PID form is deprecated, and that it may be removed in a later release. Then we can consider removing it in the future if it ever causes trouble. (I'm not suggesting you do that.) > I knew someone was going to call me on that :-). Here is the new > patch which still accepts PID. Sorry about that. :-) > I have to apologize, I just don't > have the time to get a test case for it. I hope the patch is useful > enough as it is. It sure is, thanks for persevering. > Good for the 7.2 branch too? IMO, yes. You've just given me a new chance to nit on formatting, though! :-) > + /* First see if we are dealing with a thread-group id */ Period and double space at end of sentence, like: /* First see if we are dealing with a thread-group id. */ > + if (*(argv[0]) == 'i') if (*argv[0] == 'i') Okay with those changes. -- Pedro Alves