From: Joel Brobecker <brobecker@adacore.com>
To: Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
Cc: gdb-patches@sourceware.org, Will Deacon <Will.Deacon@arm.com>,
ulrich.weigand@linaro.org
Subject: Re: [RFC] ARM support for Hardware breakpoints and watchpoints for native Linux.
Date: Tue, 09 Nov 2010 15:34:00 -0000 [thread overview]
Message-ID: <20101109153405.GJ2933@adacore.com> (raw)
In-Reply-To: <1289297254.1305.6.camel@e102319-lin.cambridge.arm.com>
> So a formal review is not necessary, but any comments on general
> approach taken are still welcome.
As far as I could tell from a quick pass, the approach seemed OK.
There were a lot of little nits (formatting), but I don't think
it would take long to bring it to a point where it can be checked in.
--
Joel
next prev parent reply other threads:[~2010-11-09 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 13:52 Matthew Gretton-Dann
2010-07-07 16:17 ` Matthew Gretton-Dann
2010-11-08 19:35 ` Joel Brobecker
2010-11-09 10:08 ` Matthew Gretton-Dann
2010-11-09 15:34 ` Joel Brobecker [this message]
2011-02-17 16:53 ` [RFC, v2] " Ulrich Weigand
2011-02-21 15:17 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109153405.GJ2933@adacore.com \
--to=brobecker@adacore.com \
--cc=Will.Deacon@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=matthew.gretton-dann@arm.com \
--cc=ulrich.weigand@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox