From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8060 invoked by alias); 4 Nov 2010 18:54:24 -0000 Received: (qmail 8052 invoked by uid 22791); 4 Nov 2010 18:54:22 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Nov 2010 18:54:18 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oA4Irr0W010274 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 4 Nov 2010 14:53:54 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oA4IrnaC002293 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 4 Nov 2010 14:53:52 -0400 Received: from host0.dyn.jankratochvil.net (localhost.localdomain [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id oA4Iri0H010386; Thu, 4 Nov 2010 19:53:45 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id oA4Irf2n010385; Thu, 4 Nov 2010 19:53:41 +0100 Date: Thu, 04 Nov 2010 18:54:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Ken Werner , Tom Tromey , gdb-patches@sourceware.org Subject: Re: Regression on gdb.ada/null_array.exp [Re: [patch] DW_AT_byte_size for array type entries] Message-ID: <20101104185341.GA10375@host0.dyn.jankratochvil.net> References: <201011031522.50715.ken@linux.vnet.ibm.com> <20101103190935.GA8853@host0.dyn.jankratochvil.net> <20101103232401.GD2445@adacore.com> <20101104003049.GA26198@host0.dyn.jankratochvil.net> <20101104015714.GE2445@adacore.com> <20101104032535.GA17310@host0.dyn.jankratochvil.net> <20101104180047.GF2445@adacore.com> <20101104180956.GA8587@host0.dyn.jankratochvil.net> <20101104182346.GH2445@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101104182346.GH2445@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00093.txt.bz2 On Thu, 04 Nov 2010 19:23:46 +0100, Joel Brobecker wrote: > > OK, so could you XFAIL it? <=gcc-4.4 or the missing ___XA type are both fine > > IMO. I will do it otherwise. > > I would do it, normally, but I think it's easier if you do it, because > I would not be able to test the XFAIL case. Checked-in. BTW I did not find any difference in the ___XA DIEs so I used the <=4.4 check. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2010-11/msg00021.html --- src/gdb/testsuite/ChangeLog 2010/11/03 14:21:58 1.2496 +++ src/gdb/testsuite/ChangeLog 2010/11/04 18:52:11 1.2497 @@ -1,3 +1,9 @@ +2010-11-04 Jan Kratochvil + Joel Brobecker + + * gdb.ada/null_array.exp (print my_table): Call get_compiler_info and + check test_compiler_info. + 2010-11-03 Ken Werner * gdb.base/gnu_vector.exp: Adjust expect messages. --- src/gdb/testsuite/gdb.ada/null_array.exp 2010/01/01 07:31:51 1.5 +++ src/gdb/testsuite/gdb.ada/null_array.exp 2010/11/04 18:52:11 1.6 @@ -37,6 +37,15 @@ set bp_location [gdb_get_line_number "START" ${testdir}/foo.adb] runto "foo.adb:$bp_location" +if [get_compiler_info ${binfile}] { + return -1; +} + +if {[test_compiler_info {gcc-[0-3]-*}] + || [test_compiler_info {gcc-4-[0-4]-*}]} { + # Ada array bounds are missing in older GCCs. + setup_xfail *-*-* +} gdb_test "print my_table" \ "= \\(\\)" \ "print my_table"