From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18525 invoked by alias); 4 Nov 2010 18:01:01 -0000 Received: (qmail 18405 invoked by uid 22791); 4 Nov 2010 18:00:59 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Nov 2010 18:00:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5003D2BACCF; Thu, 4 Nov 2010 14:00:51 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id CbbhabdSs0ah; Thu, 4 Nov 2010 14:00:51 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 12CA82BACCB; Thu, 4 Nov 2010 14:00:51 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id EEEFCF588F; Thu, 4 Nov 2010 11:00:47 -0700 (PDT) Date: Thu, 04 Nov 2010 18:01:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Ken Werner , Tom Tromey , gdb-patches@sourceware.org Subject: Re: Regression on gdb.ada/null_array.exp [Re: [patch] DW_AT_byte_size for array type entries] Message-ID: <20101104180047.GF2445@adacore.com> References: <201010191323.57251.ken@linux.vnet.ibm.com> <201010192016.05535.ken@linux.vnet.ibm.com> <201011031522.50715.ken@linux.vnet.ibm.com> <20101103190935.GA8853@host0.dyn.jankratochvil.net> <20101103232401.GD2445@adacore.com> <20101104003049.GA26198@host0.dyn.jankratochvil.net> <20101104015714.GE2445@adacore.com> <20101104032535.GA17310@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101104032535.GA17310@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00089.txt.bz2 > On Thu, 04 Nov 2010 02:57:14 +0100, Joel Brobecker wrote: > > Can you do the following and send me the whole directory? > > > > % cd testsuite/gdb.ada/null_array > > % gnatmake -g foo -cargs -save-temps -dA > > http://people.redhat.com/jkratoch/null_array.tar.gz Thanks. Finally had a chance to look at this. The debugging information appears to be incorrect (missing ___XA type to determine the array bounds). Before Ken's change, we were passing this test by pure chance, because we did: number-of-elements = array-type-len / element-len (where array-type-len is 0) if (len > 0 and get_array_bounds (...)) So we were computing the bounds only with non-zero arrays. Now, we determine the array length purely from the bounds: if (get_array_bounds (...)) I don't think we can restore the original (lucky) behavior without breaking the intent of Ken's patch. > BTW local FSF GCC 4.4.x rebuild should also make it IMO reproducible. Do the most recent compilers trigger the regresions as well? -- Joel