Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [patch] Fix stale tp->step_resume_breakpoint
Date: Tue, 02 Nov 2010 01:05:00 -0000	[thread overview]
Message-ID: <201011020105.19217.pedro@codesourcery.com> (raw)
In-Reply-To: <20101102004301.GA7972@host0.dyn.jankratochvil.net>

On Tuesday 02 November 2010 00:43:01, Jan Kratochvil wrote:
> A comment is welcome but it seems safe to me.

I think this raises an obvious question, and hints at
a larger issue: if you find you you need to tuck away step_resume_breakpoint,
then, how come you don't need to do the same for all the other execution
command state?  (step_range_start, step_range_end, step_frame_id,
continuations, etc.).
I'd assume that in the use case you trip on step_resume_breakpoint
troubles, you'd also be losing thread stepping state (or state
for any other execution command), thus your thread would end up
running free, forgetting about the previous command that was
going on before the infcall.  Is that not the case?

-- 
Pedro Alves


  reply	other threads:[~2010-11-02  1:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02  0:43 Jan Kratochvil
2010-11-02  1:05 ` Pedro Alves [this message]
2010-11-02  1:10   ` Jan Kratochvil
2010-11-24  0:52     ` obsolete: " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201011020105.19217.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox