From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30635 invoked by alias); 29 Oct 2010 20:10:05 -0000 Received: (qmail 30624 invoked by uid 22791); 29 Oct 2010 20:10:03 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 29 Oct 2010 20:09:59 +0000 Received: (qmail 11148 invoked from network); 29 Oct 2010 20:09:57 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 29 Oct 2010 20:09:57 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH] skip break-entry.exp when using a stub Date: Fri, 29 Oct 2010 20:10:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: Nathan Froyd References: <1288380040-22077-1-git-send-email-froydnj@codesourcery.com> In-Reply-To: <1288380040-22077-1-git-send-email-froydnj@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201010292109.54864.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00393.txt.bz2 On Friday 29 October 2010 20:20:40, Nathan Froyd wrote: > This patch skips gdb.base/break-entry.exp when using a stub. > prepare_for_testing already stopped the program at its entry, so the > test will not work correctly. This is okay, but I think the comment below could use some clarification/expansion. > +# If we're using a stub, we'll already be stopped at the entry point > +# when we connect. Don't bother trying to work around this in the > +# testing below. What do you think of something like this alternative: # If we're using a stub, we'll already be debugging a live # program and stopped at the entry point when we connect, # and so runto below will issue a "continue", which always # skips any breakpoint at PC. When testing with a native # target (or some other target that supports "run"), runto # will do a "run", which 1. creates the process, leaving # the PC at the entry point, just like the stub case, but then # continues the process with the equivalent of "jump *$PC", which # triggers any breakpoint at $PC. The latter is what we want # to test. ? (may need copy&editing) -- Pedro Alves