Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dan@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: Nathan Froyd <froydnj@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] fix py-inferior.exp for remote cross-endian testing
Date: Fri, 29 Oct 2010 20:16:00 -0000	[thread overview]
Message-ID: <20101029201604.GA813@caradoc.them.org> (raw)
In-Reply-To: <AANLkTi=5wwYUF0zuvftWwr=vd3sXSuvivz7mURdNc38n@mail.gmail.com>

On Fri, Oct 29, 2010 at 07:49:44PM +0000, Doug Evans wrote:
> Hi.  This patch is ok with me.
> 
> [btw, one could get the value of endianness from python with
> gdb.parameter("endian").
> Or at least should.  On my machine it returns "".
> We probably want to fix that.  Your patch is fine with me as is though.]

(gdb) py print gdb.parameter("endian")

(gdb) set endian big
The target is assumed to be big endian
(gdb) py print gdb.parameter("endian")
big
(gdb) set endian little
The target is assumed to be little endian
(gdb) py print gdb.parameter("endian")
little
(gdb) set endian auto
The target endianness is set automatically (currently little endian)
(gdb) py print gdb.parameter("endian")
auto
(gdb) show endian
The target endianness is set automatically (currently little endian)

So that's at least one obvious bug ("" vs "auto"), and one more
complex bug (what should it return for auto?).  I'm inclined to say
that it should return auto, and there should be some other way to find
out "auto what?"; OTOH, it's a general problem with parameters...

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2010-10-29 20:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-29 19:20 Nathan Froyd
2010-10-29 19:49 ` Doug Evans
2010-10-29 20:16   ` Daniel Jacobowitz [this message]
2010-11-01 20:13     ` Tom Tromey
2010-11-03 17:24       ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101029201604.GA813@caradoc.them.org \
    --to=dan@codesourcery.com \
    --cc=dje@google.com \
    --cc=froydnj@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox