From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26090 invoked by alias); 26 Oct 2010 13:39:41 -0000 Received: (qmail 26082 invoked by uid 22791); 26 Oct 2010 13:39:40 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Oct 2010 13:39:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4C5FF2BAC7E; Tue, 26 Oct 2010 09:39:30 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id aeOc5ttuiXg4; Tue, 26 Oct 2010 09:39:30 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 29FE72BAC7D; Tue, 26 Oct 2010 09:39:29 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id AA98AF59A2; Tue, 26 Oct 2010 09:39:28 -0400 (EDT) Date: Tue, 26 Oct 2010 13:39:00 -0000 From: Joel Brobecker To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix avoiding of unnecessary psymtabs in dwarf_decode_lines Message-ID: <20101026133928.GB2847@adacore.com> References: <20100825000001.9D9A484B8E@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100825000001.9D9A484B8E@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00363.txt.bz2 [I am soooo far behind on gdb patches :-(] > + file_is_pst = strcmp (include_name_to_compare, pst_filename) == 0; I know that the original code was already using strcmp to do the comparison, but shouldn't we be using FILENAME_CMP instead. That should take care of platforms where the filesystem is case insensitive... Since the patch was sent so long ago, I can make the change and do the testing, if people agree. -- Joel